Skip to content
This repository has been archived by the owner on Jun 2, 2024. It is now read-only.

Maintainer logic improve #364

Merged
merged 4 commits into from
Jul 7, 2014
Merged

Maintainer logic improve #364

merged 4 commits into from
Jul 7, 2014

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Jul 6, 2014

fengmk2 added 2 commits July 7, 2014 00:56
* fix #362 update maintianers change the lastmodified. remove version and change last modified.
* #363 change isMaintainer detect logic.
but admin user need have the permission to delete other's packages.
@@ -38,6 +38,7 @@ var logger = require('../../common/logger');
var ModuleDeps = require('../../proxy/module_deps');
var ModuleStar = require('../../proxy/module_star');
var ModuleUnpublished = require('../../proxy/module_unpublished');
var packageService = require('../../services/package');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

以后由 service 来封装一下公用的 controller 逻辑代码, service 是对 proxy 操作的合集, 有些复杂逻辑需要去多个数据取数据操作, 都由 service 来封装, 这样能简化controller, 也能更好地让controller减少冗余代码.

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 7, 2014

我再将cnpm info pkg的时候, 获取maintainers 逻辑修改一下

@fengmk2
Copy link
Member Author

fengmk2 commented Jul 7, 2014

@dead-horse all done.

dead-horse added a commit that referenced this pull request Jul 7, 2014
@dead-horse dead-horse merged commit 78af0fc into master Jul 7, 2014
@dead-horse dead-horse deleted the maintainer branch July 7, 2014 03:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants