This repository has been archived by the owner on Jun 2, 2024. It is now read-only.
fix: should sync missing public scoped package on install #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @dead-horse to be a potential reviewer |
Current coverage is 88.54%
@@ master #946 diff @@
==========================================
Files 85 85
Lines 3289 3291 +2
Methods 340 340
Messages 0 0
Branches 612 613 +1
==========================================
+ Hits 2911 2914 +3
+ Misses 378 377 -1
Partials 0 0
|
| return yield* next; | ||
| var scope = name.split('/')[0]; | ||
| // if not support scopes, don't sync | ||
| if (config.scopes.length === 0 || config.scopes.indexOf(scope) >= 0) { |
There was a problem hiding this comment.
不支持 scope 的时候为什么不同步？不支持 scope 也还是要同步公共的带 scope 的模块吧？
fengmk2
force-pushed
the
install-sync-on-public-scoped-package
branch
from
95691dd to
0b0bf0c
Compare
| if (name && name[0] === '@') { | ||
| return yield* next; | ||
| var scope = name.split('/')[0]; | ||
| if (config.scopes.indexOf(scope) >= 0) { |
There was a problem hiding this comment.
https://github.com/cnpm/cnpmjs.org/blob/master/config/index.js#L162
可能 scopes 被设置成 null ?
There was a problem hiding this comment.
好多代码都是直接依赖了 config.scopes 的，都没有做 null 检查，不管了吧。
|
+1 |
|
2.10.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #938