New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark nightly releases as draft / pre-release #459

Open

nabuskey opened this issue Nov 22, 2024 · 2 comments · Fixed by #460

Collaborator

nabuskey commented Nov 22, 2024 •

edited

Loading

We are currently marking nightly build as releases. We need to stop that.

https://docs.github.com/en/repositories/releasing-projects-on-github/managing-releases-in-a-repository

Our workflow file is here: https://github.com/cnoe-io/idpbuilder/blob/main/.github/workflows/nightly.yaml

punkwalker mentioned this issue

Updates goreleaser.yaml to mark nightly builds as pre-release #460

Merged

nabuskey closed this as completed in #460

Collaborator Author

nabuskey commented Nov 25, 2024

Reopening because #460 didn't solve this.

nabuskey reopened this

Contributor

cmoulliard commented Dec 24, 2024

This blog post should help us to fix the issue: https://github.com/ConduitIO/conduit/blob/main/.github/workflows/trigger-nightly.yml
2 flows should be created:

One to release: https://github.com/ConduitIO/conduit/blob/main/.github/workflows/release.yml
Another able to tag and clean the nightly build: https://github.com/ConduitIO/conduit/blob/main/.github/workflows/trigger-nightly.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment