Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refuse to run when incomatible settings are used #416

Closed
nabuskey opened this issue Oct 16, 2024 · 0 comments · Fixed by #418
Closed

Refuse to run when incomatible settings are used #416

nabuskey opened this issue Oct 16, 2024 · 0 comments · Fixed by #418
Labels
bug Something isn't working
Milestone

Comments

@nabuskey
Copy link
Collaborator

Currently we only check for the port we listen on to error out. e.g. if it's running on port 8443, but idpbuilder was instructed to run on port 8000, we will error out early.

We need to expand this to error out early when certain running config and given configs are different. They are:

  • use-path-routing
  • Port
  • hostname
  • extra-ports
  • kind-config
  • protocol

Once errored out, we need to instruct people to recreate.

@nabuskey nabuskey added the bug Something isn't working label Oct 16, 2024
@nabuskey nabuskey added this to the v1.0.0 milestone Oct 16, 2024
@nabuskey nabuskey changed the title Refuse to run when incomatible settings are used. Refuse to run when incomatible settings are used Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant