Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated code for creating gitserver svc urls #30

Closed
jessesanford opened this issue Oct 16, 2023 · 1 comment
Closed

Remove duplicated code for creating gitserver svc urls #30

jessesanford opened this issue Oct 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jessesanford
Copy link
Contributor

The following duplication needs to be dry'd up

pkg/controllers/localbuild/controller.go
27:     gitServerIngressHostnameBase     string = ".idpbuilder.cnoe.io.local"

pkg/controllers/gitserver/controller.go
26:     gitServerIngressHostnameBase     string = ".idpbuilder.cnoe.io.local"

pkg/apps/srv/argocd/ingress.yaml
13:  - host: argocd.idpbuilder.cnoe.io.local

Originally posted by @nimakaviani in #29 (review)
@jessesanford jessesanford self-assigned this Oct 16, 2023
@jessesanford jessesanford added the enhancement New feature or request label Oct 16, 2023
@nimakaviani nimakaviani added this to the v0.2 release milestone Oct 31, 2023
@nabuskey
Copy link
Collaborator

This was completed as part of deprecation of git server and enabling custom packages.

@jessesanford jessesanford removed their assignment Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jessesanford @nimakaviani @nabuskey