Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename the -p flag? #264

Open
nabuskey opened this issue May 28, 2024 · 2 comments
Open

Rename the -p flag? #264

nabuskey opened this issue May 28, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nabuskey
Copy link
Collaborator

Do we want to rename the --package-dir flag? Right now, it expects a directory that contain ArgoCD application files but this behaviour will likely change soonish. If that happens, we should consider changing this flag's name.

We should ensure that --package-dir flag works going forward for backward compatibility purposes though.

@cmoulliard
Copy link
Contributor

cmoulliard commented May 29, 2024

Do we want to rename the --package-dir flag?

I'm in favor to rename it in order to been able to create an IDP cluster using packages coming from different locations. Of course, that will imply that we prefix each package with a URI even if we will upload the package resources using a folder/dir

--package files:///a/b/c
--package https://
--package ssh://
--package git://
--package ftp:///

@nimakaviani
Copy link
Contributor

yeah should be an easy lift to add the new flag as an alternative and plan to deprecate this in a v0.6 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants