Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Monero to Supply Chain Compromises #967

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Add Monero to Supply Chain Compromises #967

merged 5 commits into from
Oct 14, 2022

Conversation

Rishit-dagli
Copy link
Contributor

This PR adds Monero to the list of Supply Chain compromises

Closes #822

@lumjjb lumjjb self-assigned this Aug 14, 2022
@Rishit-dagli Rishit-dagli requested a review from lumjjb August 16, 2022 10:31
@Rishit-dagli
Copy link
Contributor Author

The tests failed due to the spell check action flagging "getmonero" which should also be now fixed

@lumjjb
Copy link
Contributor

lumjjb commented Aug 16, 2022

Awesome - thanks! I think we still need the DCO: https://github.com/cncf/tag-security/pull/967/checks?check_run_id=7855919059

Let me know if you need any help with this!

@Rishit-dagli
Copy link
Contributor Author

Rishit-dagli commented Aug 16, 2022 •
edited
Loading

@lumjjb

Awesome - thanks! I think we still need the DCO: https://github.com/cncf/tag-security/pull/967/checks?check_run_id=7855919059

Let me know if you need any help with this!

Ah yes, missed that. the DCO should now pass as well

@lumjjb
Copy link
Contributor

lumjjb commented Aug 20, 2022

@Rishit-dagli just a missing update in the contents page on the compromise type, then should be good to merge!

@Rishit-dagli
Copy link
Contributor Author

@Rishit-dagli just a missing update in the contents page on the compromise type, then should be good to merge!

Fixed that now

@Rishit-dagli Rishit-dagli requested review from lumjjb and removed request for lumjjb August 21, 2022 04:38
@PushkarJ
Copy link
Contributor

Closing and re-opening pull request to test this #970

@PushkarJ PushkarJ closed this Aug 29, 2022
@PushkarJ PushkarJ reopened this Aug 29, 2022
@PushkarJ PushkarJ force-pushed the Rishit-dagli-monero branch from bb77025 to 4e2366d Compare August 29, 2022 18:03
@PushkarJ
Copy link
Contributor

PushkarJ commented Sep 3, 2022

@lumjjb this PR for some reason needs your approval / withdrawal of your request for changes in the review. Apart from this looks good to merge for me!

@Rishit-dagli @PushkarJ
Create a monero page
70b267c 
Signed-off-by: Rishit Dagli <[email protected]>
@Rishit-dagli @PushkarJ
Add Monero to the liist
63dee94 
Signed-off-by: Rishit Dagli <[email protected]>
@Rishit-dagli @PushkarJ
Update compromise type
5faafd1 
Signed-off-by: Rishit Dagli <[email protected]>
@Rishit-dagli @PushkarJ
Ignore "getmonero" from spell check
3272a4f 
Signed-off-by: Rishit Dagli <[email protected]>
@Rishit-dagli @PushkarJ
Fix compromise type
6ebccf5 
Signed-off-by: Rishit Dagli <[email protected]>
@PushkarJ PushkarJ force-pushed the Rishit-dagli-monero branch from c4efb62 to 6ebccf5 Compare October 12, 2022 03:53
@PushkarJ PushkarJ removed the request for review from lumjjb October 12, 2022 03:56
@PushkarJ PushkarJ requested a review from lumjjb October 12, 2022 03:57
@PushkarJ
Copy link
Contributor

Sorry for the wait on this @Rishit-dagli merging now!

@PushkarJ PushkarJ merged commit 613b500 into cncf:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PushkarJ PushkarJ PushkarJ approved these changes

@lumjjb lumjjb lumjjb approved these changes

@anvega anvega Awaiting requested review from anvega

@SantiagoTorres SantiagoTorres Awaiting requested review from SantiagoTorres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Monero to Supply Chain Compromises
3 participants
@Rishit-dagli @lumjjb @PushkarJ