From e9a84c302e8038fec2b33aeda9b81a949948c2f5 Mon Sep 17 00:00:00 2001 From: nikimanoledaki Date: Wed, 21 Feb 2024 18:39:06 +0100 Subject: [PATCH 1/3] Add proposal template and instructions in docs Signed-off-by: nikimanoledaki --- CONTRIBUTING.md | 12 ++ docs/proposals/README.md | 11 ++ docs/proposals/proposal-000-template.md | 203 ++++++++++++++++++++++++ 3 files changed, 226 insertions(+) create mode 100644 docs/proposals/README.md create mode 100644 docs/proposals/proposal-000-template.md diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 19d3224..52c880a 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -37,3 +37,15 @@ Recommendations for a faster Pull Request review: - **Signed**: Include a `Signed-off-by: Author Name ` in all commits by doing `git rebase HEAD~2 --signoff` (replace `~2` with the number of commits to sign) and then `git push -f`. More info [here](https://github.com/cncf-tags/green-reviews-tooling/pull/53/checks?check_run_id=21563565653). - **Verified**: [Learn more about commit signature verification with GPG.](https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification#gpg-commit-signature-verification) - The Kubernetes Best Practices for faster Reviews is a great resource for PR best practices: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews + +### Proposals + +For larger feature requests, please submit a design proposal in [docs/proposals/](./docs/proposals/). This is similar to a [Kubernetes Enhancement Proposal (KEP)](https://github.com/kubernetes/enhancements) or a [Architecture Desicision Record (ADR)](https://github.com/joelparkerhenderson/architecture-decision-record). + +First, create a copy of the template found in the proposal directory, [docs/proposals/proposal-000-template.md](./docs/proposals/proposal-000-template.md). Rename the file to the next number in the sequence and add a name for the proposal e.g. `proposal-001-my-feature.md`. Fill in the required fields, then open a PR for review. + +The initial PR can be a barebone PR with the goals/non-goals sections clarified that can be merged quickly and iterated on. + +Initial merging of the PR does not mean that the proposal is approved. The status of the PR is defined in the `Status` section. Any KEP marked as `provisional` is a working document and subject to change. + +A proposal that is accepted is a living document. Even the most well-planned ideas may change at some point. diff --git a/docs/proposals/README.md b/docs/proposals/README.md new file mode 100644 index 0000000..971243c --- /dev/null +++ b/docs/proposals/README.md @@ -0,0 +1,11 @@ +# Proposals + +How to use the proposal template: + +- Make a copy of this file in this (`docs/proposals/`) directory +- Set the name of the file to contain the next logical number and the name of the feature +- Fill out at least the Status, Motivation and Goals/Non-Goals fields. +- Open a PR to the `green-reviews-tooling` repository +- Merge early and iterate + +For more tips see the Contributing docs: https://github.com/cncf-tags/green-reviews-tooling/blob/main/CONTRIBUTING.md#proposals diff --git a/docs/proposals/proposal-000-template.md b/docs/proposals/proposal-000-template.md new file mode 100644 index 0000000..c8109da --- /dev/null +++ b/docs/proposals/proposal-000-template.md @@ -0,0 +1,203 @@ + + +# Short, descriptive title + + + +## Authors + + + +## Status + + + + + +## Table of Contents + +- [Short, descriptive title](#short-descriptive-title) + - [Authors](#authors) + - [Status](#status) + - [Table of Contents](#table-of-contents) + - [Summary](#summary) + - [Motivation](#motivation) + - [Goals](#goals) + - [Non-Goals](#non-goals) + - [Linked Docs](#linked-docs) + - [Proposal](#proposal) + - [User Stories (Optional)](#user-stories-optional) + - [Story 1](#story-1) + - [Story 2](#story-2) + - [Notes/Constraints/Caveats (Optional)](#notesconstraintscaveats-optional) + - [Risks and Mitigations](#risks-and-mitigations) + - [Design Details](#design-details) + - [Graduation Criteria (Optional)](#graduation-criteria-optional) + - [Drawbacks (Optional)](#drawbacks-optional) + - [Alternatives](#alternatives) + - [Infrastructure Needed (Optional)](#infrastructure-needed-optional) + + +## Summary + + + +## Motivation + + + +### Goals + + + +### Non-Goals + + + +### Linked Docs + + + +## Proposal + + + +### User Stories (Optional) + + + +#### Story 1 + +#### Story 2 + +### Notes/Constraints/Caveats (Optional) + + + +### Risks and Mitigations + + + +## Design Details + + + +### Graduation Criteria (Optional) + + + +## Drawbacks (Optional) + + + +## Alternatives + + + +## Infrastructure Needed (Optional) + + From ec399f308eecc1ffb02225a16798f5b74195a69a Mon Sep 17 00:00:00 2001 From: Niki Manoledaki Date: Wed, 21 Feb 2024 18:56:37 +0100 Subject: [PATCH 2/3] Update CONTRIBUTING.md Co-authored-by: Ross Fairbanks Signed-off-by: nikimanoledaki --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 52c880a..6b51b53 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,7 +40,7 @@ Recommendations for a faster Pull Request review: ### Proposals -For larger feature requests, please submit a design proposal in [docs/proposals/](./docs/proposals/). This is similar to a [Kubernetes Enhancement Proposal (KEP)](https://github.com/kubernetes/enhancements) or a [Architecture Desicision Record (ADR)](https://github.com/joelparkerhenderson/architecture-decision-record). +For larger feature requests, please submit a design proposal in [docs/proposals/](./docs/proposals/). This is similar to a [Kubernetes Enhancement Proposal (KEP)](https://github.com/kubernetes/enhancements) or a [Architecture Decision Record (ADR)](https://github.com/joelparkerhenderson/architecture-decision-record). First, create a copy of the template found in the proposal directory, [docs/proposals/proposal-000-template.md](./docs/proposals/proposal-000-template.md). Rename the file to the next number in the sequence and add a name for the proposal e.g. `proposal-001-my-feature.md`. Fill in the required fields, then open a PR for review. From d47e97143eca5460c51491bdf74288e08ee8df5f Mon Sep 17 00:00:00 2001 From: Niki Manoledaki Date: Wed, 21 Feb 2024 18:56:49 +0100 Subject: [PATCH 3/3] Update docs/proposals/proposal-000-template.md Co-authored-by: Ross Fairbanks Signed-off-by: nikimanoledaki --- CONTRIBUTING.md | 2 +- docs/proposals/proposal-000-template.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 6b51b53..76a7e44 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -40,7 +40,7 @@ Recommendations for a faster Pull Request review: ### Proposals -For larger feature requests, please submit a design proposal in [docs/proposals/](./docs/proposals/). This is similar to a [Kubernetes Enhancement Proposal (KEP)](https://github.com/kubernetes/enhancements) or a [Architecture Decision Record (ADR)](https://github.com/joelparkerhenderson/architecture-decision-record). +For larger feature requests, please submit a design proposal in [docs/proposals/](./docs/proposals/). This is similar to a [Kubernetes Enhancement Proposal (KEP)](https://github.com/kubernetes/enhancements) or a [Architecture Decision Record (ADR)](https://adr.github.io/). First, create a copy of the template found in the proposal directory, [docs/proposals/proposal-000-template.md](./docs/proposals/proposal-000-template.md). Rename the file to the next number in the sequence and add a name for the proposal e.g. `proposal-001-my-feature.md`. Fill in the required fields, then open a PR for review. diff --git a/docs/proposals/proposal-000-template.md b/docs/proposals/proposal-000-template.md index c8109da..6cb851c 100644 --- a/docs/proposals/proposal-000-template.md +++ b/docs/proposals/proposal-000-template.md @@ -33,7 +33,7 @@ rejected, withdrawn, or replaced. ## Table of Contents