Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated/Action] Install Kepler dashboard #16

Closed
rossf7 opened this issue Dec 14, 2023 · 13 comments · Fixed by #22
Closed

[Automated/Action] Install Kepler dashboard #16

rossf7 opened this issue Dec 14, 2023 · 13 comments · Fixed by #22

Comments

@rossf7
Copy link
Contributor

rossf7 commented Dec 14, 2023

Description

Grafana is installed by kube-prometheus but it would be good to be able to add our own dashboards. Likely starting with the Kepler dashboard. https://sustainable-computing.io/installation/kepler-operator/

Issue

Parent: #5

@rossf7 rossf7 changed the title Install Grafana with Flux [Automated] Install Grafana with Flux Dec 14, 2023
@rossf7 rossf7 changed the title [Automated] Install Grafana with Flux [Automated] Install Grafana dashboards with Flux Dec 19, 2023
@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented Jan 10, 2024

Thank you @rossf7, agreed! Here is a list of suggested steps.

Steps / Requirements

@nikimanoledaki nikimanoledaki added the good first issue Good for newcomers label Jan 10, 2024
@nikimanoledaki nikimanoledaki changed the title [Automated] Install Grafana dashboards with Flux [Automated/Action] Install Grafana dashboards with Flux Jan 10, 2024
@nikimanoledaki nikimanoledaki changed the title [Automated/Action] Install Grafana dashboards with Flux [Automated/Action] Install Kepler dashboard with Flux Jan 10, 2024
@nikimanoledaki nikimanoledaki changed the title [Automated/Action] Install Kepler dashboard with Flux [Automated/Action] Install Kepler dashboard with IaC Jan 10, 2024
@nikimanoledaki nikimanoledaki changed the title [Automated/Action] Install Kepler dashboard with IaC [Automated/Action] Install Kepler dashboard Jan 10, 2024
@dipankardas011
Copy link
Contributor

Currect me if I am wrong
so this issue tries to solve the import of kepler grafana dashboard to the already up and running k3s cluster provided that kepler is already successfully installed

specifically these steps for automations?
#17 (comment)

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jan 10, 2024

Thank you @rossf7, agreed! Here is a list of suggested steps.

Steps / Requirements

Also the planned PR of installing kube-prometheus already installs the grafana. so may be we might need to stop the grafana as a component install?
never see multiple grafana instances in a single k8s clusters thats why asking

@AntonioDiTuri
Copy link
Contributor

AntonioDiTuri commented Jan 10, 2024

Yes @dipankardas011 you are right when installing prometheus we also get grafana.
However two points need to be still achieved:

In order to achieve the seconds we can use gateway api with cilium

@dipankardas011
Copy link
Contributor

so for the importing dashbaord. is it manual one time operation or we are planning for automatation of this?

@rossf7
Copy link
Contributor Author

rossf7 commented Jan 10, 2024

@dipankardas011 It needs investigation but the kube-prometheus-stack helm chart includes the grafana helm chart
https://github.com/prometheus-community/helm-charts/tree/main/charts/kube-prometheus-stack

The grafana helm chart can deploy a sidecar that looks for configmaps with a label.
https://github.com/grafana/helm-charts/tree/main/charts/grafana#sidecar-for-dashboards

So we could import the Kepler dashboard as a configmap managed by Flux. Later if we need our own dashboards they could also be managed by Flux. WDYT?

@nikimanoledaki You likely know this better than I do! :) Do you think this approach makes sense?

I haven't used the Grafana TF provider. Are there benefits to using it instead of the Helm chart? With Helm we will need to use Gateway API (or Ingress) to make the Grafana instance accessible from the cluster.

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jan 11, 2024

now I am understanding thanks @rossf7

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jan 11, 2024

yes we can install the grafana dashboard without much effort

namespace doesnt matter as the sidecar looks for all the configmaps in all ns with specific label

just

apiVersion: v1
kind: ConfigMap
metadata:
  name: sample-grafana-dashboard
  labels:
     grafana_dashboard: "1"
data:
  kepler-dashboard.json: |-
    <raw...>

it works when the sidecar for the grafana in added during installing
I tested on kube-prometheus-stack
but was unable to make the kepler helm install when using kube-prometheus-stack up but was able to when using kube-prometheus

kube-prometheus-stack artifact link
https://artifacthub.io/packages/helm/prometheus-community/kube-prometheus-stack

@dipankardas011
Copy link
Contributor

may be kepler service monitor work for kube-prometheus
docs uses that 😕

@rossf7
Copy link
Contributor Author

rossf7 commented Jan 11, 2024

@dipankardas011 Nice, thanks for investigating. I think we can store it in the monitoring namespace since we're going to move kepler there. We can use kepler-dashboard for both the CM name and filename.

It would also be good to have something in docs/ for syncing the dashboard with upstream. I don't think it changes often so no need to automate that.

may be kepler service monitor work for kube-prometheus docs uses that 😕

Hmm let's wait till prometheus is deployed with kube-prometheus-stack and kepler is moved to monitoring. As having everything in the monitoring ns may help with the service monitor.

cc @AntonioDiTuri

@dipankardas011
Copy link
Contributor

was trying but it failed. so messaged in the kepler-project slack channel for there help
will be commenting in the slack

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jan 11, 2024

other than that we can easily install the kepler grafana dashboard irrespective of the prometheus stack we are using

@dipankardas011
Copy link
Contributor

dipankardas011 commented Jan 12, 2024

@rossf7 rossf7 removed the help wanted Extra attention is needed label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants