Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

there is a data race in CDI version v0.5.0 #81

Closed
soulseen opened this issue Sep 4, 2022 · 1 comment · Fixed by #82
Closed

there is a data race in CDI version v0.5.0 #81

soulseen opened this issue Sep 4, 2022 · 1 comment · Fixed by #82
Assignees
@klihub

Comments

@soulseen
Copy link

soulseen commented Sep 4, 2022

related PR: containerd/containerd#7331
this PR stuck with a data race when I wanted to update the CDI version to v0.5.0 in contained.
I suspect there is a data race error here but I can't be sure:

  1. https://github.com/container-orchestrated-devices/container-device-interface/blob/main/pkg/cdi/cache.go#L449
  2. https://github.com/container-orchestrated-devices/container-device-interface/blob/main/pkg/cdi/cache.go#L436
@elezar elezar assigned klihub and unassigned klihub Sep 5, 2022
@elezar
Copy link
Contributor

elezar commented Sep 5, 2022

@klihub could you have a look at this?

@klihub klihub mentioned this issue Sep 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@klihub klihub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix a read/write data race in the cache. klihub/container-device-interface
3 participants
@elezar @klihub @soulseen