Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground truth problem in Sachs #1

Open
cruyffturn opened this issue Jan 19, 2023 · 5 comments · Fixed by #2
Open

Ground truth problem in Sachs #1

cruyffturn opened this issue Jan 19, 2023 · 5 comments · Fixed by #2
Assignees

Comments

@cruyffturn
Copy link

cruyffturn commented Jan 19, 2023

Thank you for the package.

The edge from pip3 to plc should be reversed. 1.

@cruyffturn
Copy link
Author

Also an edge from pka to raf is missing.

@jdramsey
Copy link
Contributor

@cruyffturn Oh thanks! I'll check it out.

@jdramsey jdramsey self-assigned this Jan 19, 2023
@jdramsey
Copy link
Contributor

Huh, I pulled up the Sachs 2005 article and am staring once again at Figure 2; the edge is in fact pip3->plc. In Figure 3A, they show the plc->pip3 edge, but they show it in purple, which indicates that it is reversed. So it seems that one is OK.

However, pka->raf is definitely missing; I'll add it.

What do you think? @cruyffturn

@jdramsey jdramsey linked a pull request Jan 24, 2023 that will close this issue
@jdramsey jdramsey reopened this Jan 24, 2023
@jdramsey
Copy link
Contributor

Also sorry for the delay; I had to find a couple of minutes to get the Sachs article in front of me.

@chxliou
Copy link

chxliou commented Sep 17, 2023

In this page, https://www.bnlearn.com/research/sachs05/index.html, the direction is suggested to be plc->pip3, I am not sure which one is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants