Skip to content
This repository has been archived by the owner on Sep 27, 2019. It is now read-only.

Add a column length in ColumnCatalogObject and pg_attribute #1319

Closed
ksaito7 opened this issue Apr 20, 2018 · 4 comments
Closed

Add a column length in ColumnCatalogObject and pg_attribute #1319

ksaito7 opened this issue Apr 20, 2018 · 4 comments
Assignees
Labels

Comments

@ksaito7
Copy link
Contributor

ksaito7 commented Apr 20, 2018

Current catalog::ColumnCatalogObject class and pg_attribute table don't have column length information, although the catalog::Column class has it. Due to this, the checkpoints can't recover the catalog::Column from pg_attribute table.

@a6802739
Copy link

a6802739 commented Jun 8, 2018

@ksaito7 I'm new to this project, And I want to try to fix this. One question here is what does the column_offset means within ColumnCatalogObject?

@ksaito7
Copy link
Contributor Author

ksaito7 commented Jun 8, 2018

@a6802739 This issue has already been implemented in PR #1383 (now reviewing). Could you try other issues?
column_offset means a head location of the column in the table. It seems to be used for storage management to recognize where the column data is in the tuple. For example, assuming that a table has two columns (id interger, value varchar(36)), then id's offset is 0, and value's offset is 4.

@a6802739
Copy link

a6802739 commented Jun 8, 2018

@ksaito7 I see, Thanks a lot. Any issue would be fine for me to start, could you just point out another issue which is suitable for a beginner?

@ksaito7
Copy link
Contributor Author

ksaito7 commented Jun 19, 2018

@a6802739 You should choose an issue tagged beginner. Sorry, I don't know which is better. If you want to work for catalog issues, how about #1414?

@ksaito7 ksaito7 closed this as completed Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants