Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the GradeScope for non-CMU students is available yet? #111

Closed
ziyi-yan opened this issue Oct 14, 2020 · 9 comments
Closed

Is the GradeScope for non-CMU students is available yet? #111

ziyi-yan opened this issue Oct 14, 2020 · 9 comments

Comments

@ziyi-yan
Copy link
Contributor

This is a great course on databases. Thanks for making all these course materials available in public.

As the project 0 and 1 have passed the due date, I really hope I can test my solution against additional test cases to learn more about these projects.

@apavlo
Copy link
Member

apavlo commented Oct 16, 2020

@ziyi-yan Try access code: 5VX7JZ

@ziyi-yan
Copy link
Contributor Author

Thanks, @apavlo! I tried and succeed in entering the course. But I got a weird result for my submission of project 0. It reports that Test Failed: Test was not run. Please check the autograder!. I'm sure that I get the default basic test cases passed on my local machine.

The screenshot is pasted below.
截屏2020-10-16 下午12 05 12

@ziyi-yan
Copy link
Contributor Author

The autograder of project 1 works like a charm. Project 0 is not that important. Thanks again, @apavlo!

@apavlo
Copy link
Member

apavlo commented Oct 18, 2020

@ziyi-yan Your P0 fails the memory check.

@ziyi-yan
Copy link
Contributor Author

There are still not-run tests when I got the test_memory_safety passed.
截屏2020-10-19 下午3 53 13

@ziyi-yan ziyi-yan reopened this Oct 19, 2020
@apavlo
Copy link
Member

apavlo commented Oct 19, 2020

Look at the output. You are failing make check-format.

@apavlo apavlo closed this as completed Oct 19, 2020
@DiligentPanda
Copy link

DiligentPanda commented Oct 21, 2020

@ziyi-yan , I think the problem is you probably submit github branch instead of just a zip file with only p0_starter.h as required in the following section:
image

(I guess ) The autograder copies some files from you submission to its default code repository and use its own base codes, makefile, format-checking settings to compile the project. What probably goes wrong in your case (also mine:joy:) is that the autograder's clang-tidy setting enables modernize-use-auto(you can search it in your output from test_build) and the codes in b_plus_tree.cpp fail to pass it. This setting is however disabled in your local .clang-tidy file(by a minus prefix, you can check this file in your root directory.).

So, just follow the instructions in the project page, you will get another 100, I believe!

@lambdafate
Copy link

@DiligentPanda , You are right. I have the same problem, and i fix it by uploading the zip file. thanks for the help :)

@minleminzui
Copy link

I also encountered the same question. I fixed it. The main reason is that I used the "move" function in header file . I forgot to include it in my file before.
image

@cmu-db cmu-db locked as resolved and limited conversation to collaborators Feb 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants