Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up all files that #include legacy EDModule header #704

Closed
makortel opened this issue Oct 25, 2023 · 6 comments
Closed

Clean up all files that #include legacy EDModule header #704

makortel opened this issue Oct 25, 2023 · 6 comments
Assignees
@wddgit
Labels
Maintenance

Comments

@makortel
Copy link
Collaborator

makortel commented Oct 25, 2023 •
edited
Loading

No description provided.

@makortel makortel moved this from 🔖 Ready to 🏗 In progress in Task view (from Q3 2023 to Q2 2024) Nov 14, 2023
@makortel makortel mentioned this issue Nov 14, 2023
Closed
@wddgit
Copy link
Collaborator

wddgit commented Jan 30, 2024

cms-sw/cmssw#43817 finishes files in simulation

@wddgit
Copy link
Collaborator

wddgit commented Jan 30, 2024 •
edited
Loading

cms-sw/cmssw#43818 finishes files in daq

@wddgit
Copy link
Collaborator

wddgit commented Jan 31, 2024

cms-sw/cmssw#43829 finishes files in geometry

@wddgit
Copy link
Collaborator

wddgit commented Jan 31, 2024

cms-sw/cmssw#43832 finishes files in L1

@wddgit
Copy link
Collaborator

wddgit commented Jan 31, 2024

cms-sw/cmssw#43833 finishes files in analysis

That is the last of these PRs except maybe I should also delete FWCore/Utilities/bin/edmConvertToStreamModule.py (still thinking about whether to keep that one).

@wddgit
Copy link
Collaborator

wddgit commented Feb 1, 2024

cms-sw/cmssw#43835 removes FWCore/Utilities/bin/edmConvertToStreamModule.py. All the references to legacy modules that I could find using "git grep" will be removed as soon as all the submitted PR's are merged.

@makortel makortel closed this as completed Feb 2, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Task view (from Q3 2023 to Q2 2024) Feb 2, 2024
@makortel makortel removed the Task label Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wddgit wddgit

Labels
Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@makortel @wddgit