Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default constructor from Alpaka EDProducer base classes #47227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makortel
Copy link
Contributor

PR description:

Following #47028 and #47216 this PR removes the default constructor from Alpaka EDPRoducer base classes so that the behavior of alpaka.synchronize configuration parameter becomes well defined for all Alpaka modules.

Resolves cms-sw/framework-team#1210

PR validation:

Code compiles (with #47216)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel for master.

It involves the following packages:

  • HeterogeneousCore/AlpakaCore (heterogeneous)

@cmsbuild, @fwyzard, @makortel can you please review it and eventually sign? Thanks.
@missirol, @rovere this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

hold

This PR needs #47216 to be merged first (or simultaneously). I opened it already mostly to not forget it, as I'd like to have it merged for 15_0_0_pre3.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jan 31, 2025
@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

enable gpu

@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

please test with #47216

@fwyzard
Copy link
Contributor

fwyzard commented Jan 31, 2025

+heterogeneous

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cb222f/44111/summary.html
COMMIT: b7ad19d
CMSSW: CMSSW_15_0_X_2025-01-31-1100/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/47227/44111/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 4016770
  • DQMHistoTests: Total failures: 130
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4016620
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 218 log files, 189 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53071
  • DQMHistoTests: Total failures: 908
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52163
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@makortel
Copy link
Contributor Author

CPU comparison differences are related to #39803, #47071, and #47211

GPU comparison differences show the usual variation in pixel tracks, and a new(?) one in ParticleFlow.

@makortel
Copy link
Contributor Author

a new(?) one in ParticleFlow.

Now in #47233

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove default constructor from Alpaka EDProducer base classes
3 participants