Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change thresholds on LED and FEStatus Quality plots ECAL DQM #45429

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Change thresholds on LED and FEStatus Quality plots ECAL DQM #45429

merged 2 commits into from
Jul 15, 2024

Conversation

abhih1
Copy link
Contributor

@abhih1 abhih1 commented Jul 11, 2024 •
edited
Loading

PR description:

This PR does the following:

  1. Disables all cuts on the LED Quality plot until the experts can tune the parameters.
  2. Adds a cut on minimum no.of events to turn the FEStatus quality to RED, to reduce false alarm on transient issues.

PR validation:

PR is validated by running the ECAL online DQM configuration and verifying the plots on a test DQM GUI.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the Master PR.
Backports are made to 14_0_X #45430

@abhih1 abhih1 mentioned this pull request Jul 11, 2024
Merged
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Jul 11, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 11, 2024 •
edited
Loading

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45429/40880

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abhih1 for master.

It involves the following packages:

  • DQM/EcalMonitorClient (dqm)

@antoniovagnerini, @cmsbuild, @nothingface0, @rvenditti, @syuvivida, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @argiro, @rchatter, @thomreis, @wang0jin this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@abhih1 abhih1 mentioned this pull request Jul 11, 2024
Merged
@tjavaid
Copy link

tjavaid commented Jul 12, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-811ec3/40351/summary.html
COMMIT: 5c43000
CMSSW: CMSSW_14_1_X_2024-07-11-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/45429/40351/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

There are some workflows for which there are errors in the baseline:
29634.911 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially removed 13 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 47
  • DQMHistoTests: Total histograms compared: 3246798
  • DQMHistoTests: Total failures: 99
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3246679
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 46 files compared)
  • Checked 199 log files, 163 edm output root files, 47 DQM output files
  • TriggerResults: no differences found

nothingface0
nothingface0 reviewed Jul 12, 2024
View reviewed changes
DQM/EcalMonitorClient/src/LedClient.cc
@@ -165,6 +165,10 @@ namespace ecaldqm {

float aRmsThr(sqrt(pow(aMean * toleranceAmpRMSRatio_, 2) + pow(3., 2)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable seems to be unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but if that's commented out it will complain about other variables like toleranceAmpRMSRatio_, which would need to be commented out here as well as the header and .py files. And since this is supposed to be a temporary disabling of the cuts and would need to be reused in the future, I left it untouched to keep the changes to a minimum.

@tjavaid
Copy link

tjavaid commented Jul 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8e86c67 into cms-sw:master Jul 15, 2024
11 checks passed
This was referenced Jul 15, 2024
Merged
Merged
@smuzaffar smuzaffar mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nothingface0 nothingface0 nothingface0 left review comments

Assignees
No one assigned
Labels
code-checks-approved dqm-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
5 participants
@abhih1 @cmsbuild @tjavaid @rappoccio @nothingface0