Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphical improvements for TrackerAlignment_PayloadInspector #41205

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Graphical improvements for TrackerAlignment_PayloadInspector #41205

merged 2 commits into from
Mar 28, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 28, 2023

PR description:

This is a quick follow-up to:

  • 82c3b9a simplifies loops in TrackerAlignment_PayloadInspector
  • 21297e6 improves the TrackerAlignmentSummary* plot legends and testing script

PR validation:

Validated with private script:

#!/bin/bash

# Save current working dir so img can be outputted there later
W_DIR=$(pwd);

cd $W_DIR;
source /afs/cern.ch/cms/cmsset_default.sh;
eval `scram run -sh`;

mkdir -p $W_DIR/results_alignments

#*************************************************************************#
elements=(BPix FPix TIB TOB TID TEC)

for i in "${elements[@]}"
do
    echo "Processing: $i partition"
    
    getPayloadData.py  \
 	--plugin pluginTrackerAlignment_PayloadInspector \
 	--plot plot_TrackerAlignmentSummary${i} \
 	--tag TrackerAlignment_PCL_byRun_v2_express \
 	--time_type Run \
	--iovs '{"start_iov": "303809", "end_iov": "303886"}' \
  	--db Prod \
 	--test;
    
    mv *.png $W_DIR/results_alignments/TrackerAlignmentSummary${i}.png

    getPayloadData.py  \
 	--plugin pluginTrackerAlignment_PayloadInspector \
 	--plot plot_TrackerAlignmentSummary${i}TwoTags \
 	--tag TrackerAlignment_Upgrade2026_T21_design_v0 \
 	--tagtwo TrackerAlignment_Phase2_T21_misalignmentTest_FullTracker_v0 \
 	--time_type Run \
	--iovs '{"start_iov": "1", "end_iov": "1"}' \
	--iovstwo '{"start_iov": "1", "end_iov": "1"}' \
  	--db Prep \
 	--test;
    
    mv *.png $W_DIR/results_alignments/TrackerAlignmentSummary${i}TwoTags.png    
done

obtained plots are here

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild cmsbuild added this to the CMSSW_13_1_X milestone Mar 28, 2023
@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41205/34904

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@mmusich mmusich force-pushed the adaptTkAlForPhase2 branch from 21297e6 to fe886e1 Compare March 28, 2023 08:28
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41205/34905

  • This PR adds an extra 28KB to repository

  • There are other open Pull requests which might conflict with changes you have proposed:

@mmusich
Copy link
Contributor Author

mmusich commented Mar 28, 2023

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CondCore/AlignmentPlugins (db)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42c025/31634/summary.html
COMMIT: fe886e1
CMSSW: CMSSW_13_1_X_2023-03-27-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41205/31634/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3554236
  • DQMHistoTests: Total failures: 898
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3553316
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 28, 2023

+db

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8306e08 into cms-sw:master Mar 28, 2023
@mmusich mmusich deleted the adaptTkAlForPhase2 branch March 28, 2023 14:19
This was referenced Mar 28, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_1_X
Development

Successfully merging this pull request may close these issues.
4 participants
@mmusich @cmsbuild @tvami @perrotta