RecoTauTag/RecoTau: array bounds warning/error found in gcc 13.3.1 build #47219

gartung · 2025-01-30T23:33:45Z

In static member function 'static constexpr _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = const float; _Up = float; bool _IsMove = false]',
    inlined from 'constexpr _OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:506:30,
    inlined from 'constexpr _OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:533:42,
    inlined from 'constexpr _OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:540:31,
    inlined from 'constexpr _OI std::copy(_II, _II, _OI) [with _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:633:7,
    inlined from 'constexpr void std::vector<_Tp, _Alloc>::_M_assign_aux(_ForwardIterator, _ForwardIterator, std::forward_iterator_tag) [with _ForwardIterator = const float*; _Tp = float; _Alloc = std::allocator<float>]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/vector.tcc:341:15,
    inlined from 'constexpr std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(std::initializer_list<_Tp>) [with _Tp = float; _Alloc = std::allocator<float>]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_vector.h:790:21,
    inlined from 'virtual reco::SingleTauDiscriminatorContainer reco::tau::PATTauDiscriminationByMVAIsolationRun2::discriminate(const TauDiscriminationProducerBase<pat::Tau, edm::ValueMap<reco::SingleTauDiscriminatorContainer>, reco::SingleTauDiscriminatorContainer, pat::PATTauDiscriminator>::TauRef&) const' at src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc:187:30:
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:437:30: error: 'void* __builtin_memmove(void*, const void*, long unsigned int)' forming offset 4 is out of the bounds [0, 4] of object '<anonymous>' with type 'const float [1]' [-Werror=array-bounds=]
   437 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc: In member function 'virtual reco::SingleTauDiscriminatorContainer reco::tau::PATTauDiscriminationByMVAIsolationRun2::discriminate(const TauDiscriminationProducerBase<pat::Tau, edm::ValueMap<reco::SingleTauDiscriminatorContainer>, reco::SingleTauDiscriminatorContainer, pat::PATTauDiscriminator>::TauRef&) const':
src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc:187:30: note: '<anonymous>' declared here
  187 |       result.rawValues = {-1.};
      |                              ^
In static member function 'static constexpr _Up* std::__copy_move<_IsMove, true, std::random_access_iterator_tag>::__copy_m(_Tp*, _Tp*, _Up*) [with _Tp = const float; _Up = float; bool _IsMove = false]',
    inlined from 'constexpr _OI std::__copy_move_a2(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:506:30,
    inlined from 'constexpr _OI std::__copy_move_a1(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:533:42,
    inlined from 'constexpr _OI std::__copy_move_a(_II, _II, _OI) [with bool _IsMove = false; _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:540:31,
    inlined from 'constexpr _OI std::copy(_II, _II, _OI) [with _II = const float*; _OI = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:633:7,
    inlined from 'static _ForwardIterator std::__uninitialized_copy<true>::__uninit_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = const float*; _ForwardIterator = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_uninitialized.h:147:27,
    inlined from '_ForwardIterator std::uninitialized_copy(_InputIterator, _InputIterator, _ForwardIterator) [with _InputIterator = const float*; _ForwardIterator = float*]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_uninitialized.h:185:15,
    inlined from 'constexpr _ForwardIterator std::__uninitialized_copy_a(_InputIterator, _InputIterator, _ForwardIterator, allocator<_Tp>&) [with _InputIterator = const float*; _ForwardIterator = float*; _Tp = float]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_uninitialized.h:373:37,
    inlined from 'constexpr void std::vector<_Tp, _Alloc>::_M_assign_aux(_ForwardIterator, _ForwardIterator, std::forward_iterator_tag) [with _ForwardIterator = const float*; _Tp = float; _Alloc = std::allocator<float>]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/vector.tcc:345:35,
    inlined from 'constexpr std::vector<_Tp, _Alloc>& std::vector<_Tp, _Alloc>::operator=(std::initializer_list<_Tp>) [with _Tp = float; _Alloc = std::allocator<float>]' at /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_vector.h:790:21,
    inlined from 'virtual reco::SingleTauDiscriminatorContainer reco::tau::PATTauDiscriminationByMVAIsolationRun2::discriminate(const TauDiscriminationProducerBase<pat::Tau, edm::ValueMap<reco::SingleTauDiscriminatorContainer>, reco::SingleTauDiscriminatorContainer, pat::PATTauDiscriminator>::TauRef&) const' at src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc:187:30:
  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc13/external/gcc/13.3.1-92b2d78dc343ed2bc93c8eb414ddc9ff/include/c++/13.3.1/bits/stl_algobase.h:437:30: error: 'void* __builtin_memmove(void*, const void*, long unsigned int)' offset [-9223372036854775803, -1] is out of the bounds [0, 4] of object '<anonymous>' with type 'const float [1]' [-Werror=array-bounds=]
   437 |             __builtin_memmove(__result, __first, sizeof(_Tp) * _Num);
      |             ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc: In member function 'virtual reco::SingleTauDiscriminatorContainer reco::tau::PATTauDiscriminationByMVAIsolationRun2::discriminate(const TauDiscriminationProducerBase<pat::Tau, edm::ValueMap<reco::SingleTauDiscriminatorContainer>, reco::SingleTauDiscriminatorContainer, pat::PATTauDiscriminator>::TauRef&) const':
src/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc:187:30: note: '<anonymous>' declared here
  187 |       result.rawValues = {-1.};
      |                              ^

The text was updated successfully, but these errors were encountered:

cmsbuild · 2025-01-30T23:34:02Z

cms-bot internal usage

cmsbuild · 2025-01-30T23:34:02Z

A new Issue was created by @gartung.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel · 2025-01-30T23:41:30Z

This looks like a compiler bug (similar to #47218)

cmssw/RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc

Lines 186 to 187 in a621796

    
           reco::SingleTauDiscriminatorContainer result; 
        
           result.rawValues = {-1.};

cmssw/DataFormats/TauReco/interface/TauDiscriminatorContainer.h

Line 10 in a621796

    
           std::vector<float> rawValues;     // stores floating point discriminators, like MVA raw values or pt sums.

makortel · 2025-01-30T23:41:35Z

assign core

cmsbuild · 2025-01-30T23:41:49Z

New categories assigned: core

@Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

gartung · 2025-01-31T00:00:13Z

Apparent you have to specify 1.0 is float with 1.f
https://gcc.gnu.org/gcc-13/porting_to.html

makortel · 2025-01-31T00:08:43Z

Could you try if result.rawValues = {-1.f}; would silence the warning? (although given similar warning in #47218 with int I don't have high hopes)

gartung · 2025-01-31T00:12:44Z

OK

gartung · 2025-01-31T01:15:44Z

Unfortunately it didn't work.

cmsbuild added the pending-assignment label Jan 30, 2025

cmsbuild added core-pending pending-signatures and removed pending-assignment labels Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RecoTauTag/RecoTau: array bounds warning/error found in gcc 13.3.1 build #47219

RecoTauTag/RecoTau: array bounds warning/error found in gcc 13.3.1 build #47219

gartung commented Jan 30, 2025

cmsbuild commented Jan 30, 2025 •

edited

Loading

cmsbuild commented Jan 30, 2025

makortel commented Jan 30, 2025

makortel commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

gartung commented Jan 31, 2025

makortel commented Jan 31, 2025

gartung commented Jan 31, 2025

gartung commented Jan 31, 2025

RecoTauTag/RecoTau: array bounds warning/error found in gcc 13.3.1 build #47219

RecoTauTag/RecoTau: array bounds warning/error found in gcc 13.3.1 build #47219

Comments

gartung commented Jan 30, 2025

cmsbuild commented Jan 30, 2025 • edited Loading

cmsbuild commented Jan 30, 2025

makortel commented Jan 30, 2025

makortel commented Jan 30, 2025

cmsbuild commented Jan 30, 2025

gartung commented Jan 31, 2025

makortel commented Jan 31, 2025

gartung commented Jan 31, 2025

gartung commented Jan 31, 2025

cmsbuild commented Jan 30, 2025 •

edited

Loading