Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve testing of ECAL-laser-farm workflow(s) #45450

Closed
missirol opened this issue Jul 15, 2024 · 10 comments
Closed

improve testing of ECAL-laser-farm workflow(s) #45450

missirol opened this issue Jul 15, 2024 · 10 comments

Comments

@missirol
Copy link
Contributor

The updates in #44892 addressed #44643 (although I see the latter issue is still open, so maybe there is more to it). They were first tested online using CMSSW_14_0_7_HLTTest, then deployed as part of CMSSW_14_0_9. More details can be found in CMSHLT-3230.

This update led to a problem in the production jobs running in the ECAL laser farm. This was caught only after deploying the update online, and it was promptly fixed in #45247 (which was backported and included in CMSSW_14_0_9_patch1 and CMSSW_14_0_10).

Given that the issue was not caught during PR tests nor IBs, it looks like the production workflows running in the ECAL laser farm are not fully tested in CMSSW [*].

It would be useful to add/improve these tests, in order to avoid similar issues in the future.

[*] For what I understood, at least one of these workflows uses as input source an instance of StreamerInputModule (maybe WatcherSource). I see there are tests related to WatcherSource in CalibCalorimetry/EcalLaserSorting/test/, but apparently these passed during the testing of #44892.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 15, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

A new Issue was created by @missirol.

@Dr15Jones, @antoniovilela, @makortel, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign alca

(I guess, not sure if other areas need to be included)

@cmsbuild
Copy link
Contributor

New categories assigned: alca

@saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks

@mmusich
Copy link
Contributor

mmusich commented Jul 15, 2024

(I guess, not sure if other areas need to be included)

daq sounds like a safe bet

@makortel
Copy link
Contributor

assign daq

@cmsbuild
Copy link
Contributor

New categories assigned: daq

@emeschi,@smorovic you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smorovic
Copy link
Contributor

I debugged again this problem and it turns out it was triggered only when multiple metadata event were found in one streamer file...this is the reason why there is no crash with current test, which generated files contain only one metadata event (i.e. no merging from multiple processes).

I am expanding EventFilter/Utilities test, which already runs DQM-like configuration, to run WatcherSource configuration on files merged from two processes.

While we could modify CalibCalorimetry/EcalLaserSorting tests, this would have to reuse DAQ test configuration files, so we can as well have it EvF/Utilities area. Another benefit is that DQM test will also be done with files merged from two processes, which isn't the case now.

@smorovic
Copy link
Contributor

Test added with #45465
I think backport is not needed (any changes that can cause problems here will need to be backported from master).

@missirol
Copy link
Contributor Author

Thanks @smorovic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants