-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve testing of ECAL-laser-farm workflow(s) #45450
Comments
cms-bot internal usage |
A new Issue was created by @missirol. @Dr15Jones, @antoniovilela, @makortel, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign alca (I guess, not sure if other areas need to be included) |
New categories assigned: alca @saumyaphor4252,@perrotta,@consuegs you have been requested to review this Pull request/Issue and eventually sign? Thanks |
daq sounds like a safe bet |
assign daq |
I debugged again this problem and it turns out it was triggered only when multiple metadata event were found in one streamer file...this is the reason why there is no crash with current test, which generated files contain only one metadata event (i.e. no merging from multiple processes). I am expanding While we could modify |
Test added with #45465 |
Thanks @smorovic ! |
The updates in #44892 addressed #44643 (although I see the latter issue is still open, so maybe there is more to it). They were first tested online using
CMSSW_14_0_7_HLTTest
, then deployed as part ofCMSSW_14_0_9
. More details can be found in CMSHLT-3230.This update led to a problem in the production jobs running in the ECAL laser farm. This was caught only after deploying the update online, and it was promptly fixed in #45247 (which was backported and included in
CMSSW_14_0_9_patch1
andCMSSW_14_0_10
).Given that the issue was not caught during PR tests nor IBs, it looks like the production workflows running in the ECAL laser farm are not fully tested in CMSSW [*].
It would be useful to add/improve these tests, in order to avoid similar issues in the future.
[*] For what I understood, at least one of these workflows uses as input source an instance of
StreamerInputModule
(maybeWatcherSource
). I see there are tests related toWatcherSource
inCalibCalorimetry/EcalLaserSorting/test/
, but apparently these passed during the testing of #44892.The text was updated successfully, but these errors were encountered: