Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve data-integrity check in ECAL GPU unpacker #42090

Closed
missirol opened this issue Jun 26, 2023 · 9 comments
Closed

Improve data-integrity check in ECAL GPU unpacker #42090

missirol opened this issue Jun 26, 2023 · 9 comments

Comments

@missirol
Copy link
Contributor

missirol commented Jun 26, 2023

#41977 was integrated in 13_2_X as a potential solution to #39568 (and it was also backported to 13_0_X and 13_1_X).

Even after #41977, the treatment of integrity errors in the ECAL GPU unpacker is not yet identical to one in the ECAL CPU unpacker (see #41977 (comment) and replies), and this should be improved.

Attn: @cms-sw/ecal-dpg-l2

@cmsbuild
Copy link
Contributor

A new Issue was created by @missirol Marino Missiroli.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

assign hlt

(Not strictly an HLT issue, but relevant to HLT.)

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor

assign reconstruction, heterogeneous

@cmsbuild
Copy link
Contributor

New categories assigned: heterogeneous,reconstruction

@mandrenguyen,@fwyzard,@clacaputo,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@thomreis
Copy link
Contributor

type ecal

@thomreis
Copy link
Contributor

An improved version can be found in PR #42301.

@missirol
Copy link
Contributor Author

missirol commented Aug 1, 2023

+hlt

Addressed in #42301 (which will be included in 13_3_0_pre1), and backported down to the 13_0_X cycle (#42394, #42406, #42395).

@missirol
Copy link
Contributor Author

please close

Closing this issue. @cms-sw/heterogeneous-l2 and @cms-sw/reconstruction-l2 already signed the corresponding PR, so I assume they agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants