Segmentation violation on Prompt Reco in pp collision run for lowPtGsfEleGsfTracks #41442
Comments
|
A new Issue was created by @malbouis . @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
|
assign reconstruction |
1 similar comment
|
assign reconstruction |
|
New categories assigned: reconstruction @mandrenguyen,@clacaputo you have been requested to review this Pull request/Issue and eventually sign? Thanks |
cmsbuild
added
reconstruction-pending
pending-signatures
and removed
pending-assignment
labels
|
type egamma |
|
Compiling with debug symbols I get the following stack trace: so it seems it's originated here: https://cmssdt.cern.ch/dxr/CMSSW/source/TrackingTools/GsfTools/interface/GetComponents.h#6 |
|
also for the record: diff --git a/TrackingTools/GsfTracking/src/GsfMultiStateUpdator.cc b/TrackingTools/GsfTracking/src/GsfMultiStateUpdator.cc
index f3d6d173c10..2429ac9a6f0 100644
--- a/TrackingTools/GsfTracking/src/GsfMultiStateUpdator.cc
+++ b/TrackingTools/GsfTracking/src/GsfMultiStateUpdator.cc
@@ -12,6 +12,10 @@
TrajectoryStateOnSurface GsfMultiStateUpdator::update(const TrajectoryStateOnSurface& tsos,
const TrackingRecHit& aRecHit) const {
+ if (!tsos.isValid()) {
+ edm::LogError("GsfMultiStateUpdator") << "Trying to update trajectory state with invalid TSOS! ";
+ return TrajectoryStateOnSurface();
+ }
GetComponents comps(tsos);
auto const& predictedComponents = comps();
if (predictedComponents.empty()) {this solves (up to reco to decide if that's acceptable). @swagata87 FYI. |
|
I thought that all invalid tsos cases were already fixed or gracefully skipped in GSF. Apparently not. |
|
TSOS is a good candidate to move to std::optional. |
|
Thanks for the fix, Marco! I have checked on 1000 MC events from I do not see any change in distributions of electron pT, eta, dEta(supercluster_seed,inner_track) etc. So the fix seems reasonable to me. |
|
Thanks @swagata87 and @mmusich |
Thank you, Vincenzo. If it's okay, we can go with Marco's fix for now, so that this immediate issue is quickly wrapped up. |
|
There's a possibly related crash that shows up in the arm64 relvals, |
|
The fix for this issue has been integrated into the new release, CMSSW_13_0_5 that has just been built. @cms-sw/reconstruction-l2 if it's ok with you, I will close this issue. |
|
+reconstruction |
cmsbuild
added
reconstruction-approved
fully-signed
and removed
reconstruction-pending
pending-signatures
labels
|
This issue is fully signed and ready to be closed. |
|
@cmsbuild, please close |
There is a paused job in the Tier0 prompt reco processing due to a segmentation violation on
lowPtGsfEleGsfTracks.It is failing on the processing of a pp collision run 366497, on dataset EphemeralZeroBias.
The tar file can be found at https://eoscmsweb.cern.ch/eos/cms/store/logs/prod/recent/PromptReco/PromptReco_Run366497_EphemeralZeroBias14/Reco
The crash is below:
The text was updated successfully, but these errors were encountered: