Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FedRawDataInputSource: warning: 'newChunk' may be used uninitialized in this function #40946

Closed
iarspider opened this issue Mar 3, 2023 · 9 comments

Comments

@iarspider
Copy link
Contributor

A warning is issued in DBG_X IB CMSSW_13_1_DBG_X_2023-03-02-2300:

.../src/EventFilter/Utilities/src/FedRawDataInputSource.cc: In member function 'readSupervisor':
  .../src/EventFilter/Utilities/interface/FedRawDataInputSource.h:202:13: warning: 'newChunk' may be used uninitialized in this function [-Wmaybe-uninitialized]
   202 |     offset_ = newOffset;
      |             ^
.../src/EventFilter/Utilities/src/FedRawDataInputSource.cc:1205:21: note: 'newChunk' was declared here
 1205 |         InputChunk* newChunk;
      |                     ^

Full log: link

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

A new Issue was created by @iarspider .

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Mar 3, 2023

assign daq

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

New categories assigned: daq

@smorovic,@emeschi you have been requested to review this Pull request/Issue and eventually sign? Thanks

@smorovic
Copy link
Contributor

smorovic commented Mar 3, 2023

This is in the single-buffer mode that we don't use (and in fact will go away in the new input source for run3+phase2 that is in development).
I will prepare a patch to intialize variable and add checks to to avoid potential crash here.

@makortel
Copy link
Contributor

makortel commented Mar 6, 2023

Fixed in #40953

@makortel
Copy link
Contributor

makortel commented Mar 6, 2023

I suppose this issue could be closed now. @smorovic could you sign it?

@smorovic
Copy link
Contributor

smorovic commented Mar 6, 2023

+1
yes, it was merged.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

This issue is fully signed and ready to be closed.

@makortel
Copy link
Contributor

makortel commented Mar 6, 2023

@cmsbuild, please close

@cmsbuild cmsbuild closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants