-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue in matching between HLT object and L1 object #39809
Comments
A new Issue was created by @jaimeleonh Jaime Leon Holgado. @Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign xpog |
Thanks for reporting @jaimeleonh , this looks like a bug indeed. I will make a PR to fix it and backport it to 124X. However we are planning to change the way trigger object info is stored in nano as this is not the only issue with the TriggerObjectTableProducer... |
urgent |
This issue is fully signed and ready to be closed. |
When running the nanoAOD production, in https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/plugins/TriggerObjectTableProducer.cc#L252-L255 there's a loop that tries to find the L1 object that best matches (in dR) with the desired HLT object. However, the
best
value is not getting updated, so the last L1object from the collection whose dR with the HLT object is smaller thansel.l1DR2
(which to be true I'm not sure what is), is the one getting stored, even if there's a previous one with an smaller dR. Is this behaviour intended?The text was updated successfully, but these errors were encountered: