Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chaining toReplaceWith #39335

Closed
vlimant opened this issue Sep 7, 2022 · 7 comments · Fixed by #39342
Closed

chaining toReplaceWith #39335

vlimant opened this issue Sep 7, 2022 · 7 comments · Fixed by #39342

Comments

@vlimant
Copy link
Contributor

vlimant commented Sep 7, 2022

I was wondering if there is a major issue with allowing

(Modifier_A | Modifier_B).toReplaceWith(something, something_else).toReplaceWith(something_dfiferent, something_else_different)

instead of

(Modifier_A | Modifier_B).toReplaceWith(something, something_else) (Modifier_A | Modifier_B).toReplaceWith(something_dfiferent, something_else_different)

and for other modifier functions

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

A new Issue was created by @vlimant vlimant.

@Dr15Jones, @perrotta, @dpiparo, @rappoccio, @makortel, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

makortel commented Sep 7, 2022

assign core

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 7, 2022

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor

makortel commented Sep 7, 2022

Thanks for the suggestion, the chaining of toModify() and toReplaceWith() function calls is implemented in #39342

@vlimant
Copy link
Contributor Author

vlimant commented Sep 8, 2022

awesome !

@makortel
Copy link
Contributor

makortel commented Sep 9, 2022

+core

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2022

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants