-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HGCAL] Add CloseByPGun sample to the list of RelVals run at IB level #36832
Comments
assign upgrade |
New categories assigned: upgrade @AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Issue was created by @rovere Marco Rovere. @Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
I would need comments from @smuzaffar @perrotta @qliphy on the resource used for the short matrix. Here is the list of the short matrix, I think we will need to find a balance between used resources as the test will be done in all PRs including Run-3 and usefulness for groups. I don't have a strong opinion on this. Adding a small NoPU workflow should not be a big deal, but we can't always add fail things to the PR test also. |
Ciao @srimanob let's hear from @smuzaffar @perrotta and @qliphy about resource usage and availability. |
@rovere , any idea of the resources (cpu, memory) these workflows need? We do have good machines (16 cores with over 128GB memory) so if there is not a huge resource requirement ( and new workflows run in reasonable time e.g. under an hour/workflow) then I have no objections adding these for IB validations. |
Ciao @smuzaffar I do not have numbers, but this specific workflow should be much less demanding than any other real |
Hi @smuzaffar @rovere
Note to myself that I should update also https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/README.md in the PR, to add .201, .202 |
Ciao @srimanob how many choices am I allowed to make 😄 ? |
Hi @rovere |
Ciao @srimanob |
OK, then I propose to have them in both places for HGCAL development. @smuzaffar Could you please help for IB? Thanks. |
+Upgrade Two CloseByPGun wfs are running in IB now as they are in relvals_2026. I think the issue can be closed. |
This issue is fully signed and ready to be closed. |
Thanks to everyone that helped! |
Given the recent crash (#36800) related to the
CloseByPGun
event generator, and taking into account its paramount importance in performing the release validation for HGCAL, it would be wise to add a couple of CloseByPGun workflows in the set of RelVals that are run at every IB integration.The text was updated successfully, but these errors were encountered: