Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HGCAL] Add CloseByPGun sample to the list of RelVals run at IB level #36832

Closed
rovere opened this issue Jan 29, 2022 · 16 comments
Closed

[HGCAL] Add CloseByPGun sample to the list of RelVals run at IB level #36832

rovere opened this issue Jan 29, 2022 · 16 comments

Comments

@rovere
Copy link
Contributor

rovere commented Jan 29, 2022

Given the recent crash (#36800) related to the CloseByPGun event generator, and taking into account its paramount importance in performing the release validation for HGCAL, it would be wise to add a couple of CloseByPGun workflows in the set of RelVals that are run at every IB integration.

@rovere
Copy link
Contributor Author

rovere commented Jan 29, 2022

assign upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: upgrade

@AdrianoDee,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @rovere Marco Rovere.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@srimanob
Copy link
Contributor

I would need comments from @smuzaffar @perrotta @qliphy on the resource used for the short matrix.

Here is the list of the short matrix,
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/scripts/runTheMatrix.py#L60-L103

I think we will need to find a balance between used resources as the test will be done in all PRs including Run-3 and usefulness for groups. I don't have a strong opinion on this. Adding a small NoPU workflow should not be a big deal, but we can't always add fail things to the PR test also.

@rovere
Copy link
Contributor Author

rovere commented Jan 30, 2022

Ciao @srimanob let's hear from @smuzaffar @perrotta and @qliphy about resource usage and availability.
At the same time, I currently count 5 Upgrade workflows over a total of ~40 (I'm not including your #36833): bringing it so 6 (with a very fast workflow, as CloseByPGun is, without PU), would not represent a huge deal, IMHO.
Having said that, I'd be happy as well if the CloseByPGun is tested during the IB Relval testing, and not at each and every PR testing, if resources would not allow that (that was, in fact, my original proposal). Let's see.

@smuzaffar
Copy link
Contributor

@rovere , any idea of the resources (cpu, memory) these workflows need? We do have good machines (16 cores with over 128GB memory) so if there is not a huge resource requirement ( and new workflows run in reasonable time e.g. under an hour/workflow) then I have no objections adding these for IB validations.

@rovere
Copy link
Contributor Author

rovere commented Jan 30, 2022

Ciao @smuzaffar I do not have numbers, but this specific workflow should be much less demanding than any other real PhaseII workflow, since it's a single particle one, usually shot immediately in front of (or in between) HGCAL.

@srimanob
Copy link
Contributor

Hi @smuzaffar @rovere
OK, I will include the new workflow in my PR, and put the number for the reference. It is single particle, it should take less than ttbar NoPU. Do you have preference @rovere

  • 39493.0 2026D88+CloseByParticle_Photon_ERZRanges_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39494.0 2026D88+CE_E_Front_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39494.201 2026D88_ticl_clue3D+CE_E_Front_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39494.202 2026D88_ticl_FastJet+CE_E_Front_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39495.0 2026D88+CE_E_Front_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39495.201 2026D88_ticl_clue3D+CE_E_Front_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39495.202 2026D88_ticl_FastJet+CE_E_Front_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39496.0 2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39496.201 2026D88_ticl_clue3D+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39496.202 2026D88_ticl_FastJet+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39497.0 2026D88+CE_H_Fine_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39497.201 2026D88_ticl_clue3D+CE_H_Fine_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39497.202 2026D88_ticl_FastJet+CE_H_Fine_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39498.0 2026D88+CE_H_Fine_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39498.201 2026D88_ticl_clue3D+CE_H_Fine_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39498.202 2026D88_ticl_FastJet+CE_H_Fine_200um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39499.0 2026D88+CE_H_Fine_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39499.201 2026D88_ticl_clue3D+CE_H_Fine_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39499.202 2026D88_ticl_FastJet+CE_H_Fine_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39500.0 2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39500.201 2026D88_ticl_clue3D+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39500.202 2026D88_ticl_FastJet+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39501.0 2026D88+CE_H_Coarse_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39501.201 2026D88_ticl_clue3D+CE_H_Coarse_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • 39501.202 2026D88_ticl_FastJet+CE_H_Coarse_300um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal

Note to myself that I should update also https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/README.md in the PR, to add .201, .202

@rovere
Copy link
Contributor Author

rovere commented Jan 31, 2022

Ciao @srimanob how many choices am I allowed to make 😄 ?
I'd use 39496.0 as a representative test in order to regularly exercise the CloseByPGun, unless someone else has a different opinion on that: @apsallid @felicepantaleo @cseez @pfs

@apsallid
Copy link
Contributor

@rovere @srimanob @cseez @pfs
If we were allowed for one more I would also propose a scintillator workflow (39500.0 apart from 39496.0).

@srimanob
Copy link
Contributor

srimanob commented Feb 1, 2022

Hi @rovere
To clarify, you propose the additional workflow to be added in the short matrix (tested with every PR), or IB. From the title, it seems the latter, but from the discussion, I talked about the former. Thanks.

@rovere
Copy link
Contributor Author

rovere commented Feb 1, 2022

Ciao @srimanob
my proposal was to add them to the IB. Since, though, the CloseByPGun is very fast, I'd not mind also the short matrix option.

@srimanob
Copy link
Contributor

srimanob commented Feb 1, 2022

OK, then I propose to have them in both places for HGCAL development. @smuzaffar Could you please help for IB? Thanks.

@srimanob
Copy link
Contributor

srimanob commented Feb 3, 2022

+Upgrade

Two CloseByPGun wfs are running in IB now as they are in relvals_2026. I think the issue can be closed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

This issue is fully signed and ready to be closed.

@rovere
Copy link
Contributor Author

rovere commented Feb 3, 2022

Thanks to everyone that helped!

@rovere rovere closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants