Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CkfTrackCandidateMaker lacks fillDescriptions method #35344

Closed
missirol opened this issue Sep 20, 2021 · 8 comments
Closed

CkfTrackCandidateMaker lacks fillDescriptions method #35344

missirol opened this issue Sep 20, 2021 · 8 comments

Comments

@missirol
Copy link
Contributor

It was noted in #35309 that the plugin CkfTrackCandidateMaker is currently lacking a fillDescriptions method (see comment).

I was wondering if (tracking?) experts could have a look.

@cmsbuild
Copy link
Contributor

A new Issue was created by @missirol Marino Missiroli.

@Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@missirol missirol changed the title CkfTrackCandidateMaker lacks fillDescriptions method CkfTrackCandidateMaker lacks fillDescriptions method Sep 20, 2021
@makortel
Copy link
Contributor

assign reconstruction

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@jpata you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Sep 20, 2021

@mtosi @vmariani @mmusich
please check and perhaps assign to someone in TRK POG.
Thank you.

@mmusich
Copy link
Contributor

mmusich commented Sep 21, 2021

@slava77 @missirol
At the moment there's no manpower available for this in the POG.
If it's urgent please feel free to implement it - we'll review.
Thanks

@mmusich
Copy link
Contributor

mmusich commented Sep 23, 2021

@slava77 @missirol
I came up with #35385 in the spare time. It's completely un-validated at this point, but feel free to comment if that's what you need (in the meanwhile I'll run privately integration tests).

@missirol
Copy link
Contributor Author

Thanks, Marco. I'll try to see if this can help with #35309.

@missirol
Copy link
Contributor Author

I think #36459 and #36658 addressed this issue (and tested okay in IBs), so I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants