Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeTrackValidationPlots.py crashes #34420

Closed
VinInn opened this issue Jul 9, 2021 · 9 comments · Fixed by #34430
Closed

makeTrackValidationPlots.py crashes #34420

VinInn opened this issue Jul 9, 2021 · 9 comments · Fixed by #34430

Comments

@VinInn
Copy link
Contributor

VinInn commented Jul 9, 2021

was ok in CMSSW_12_0_X_2021-06-30-2300 (that is still around)

Traceback (most recent call last):
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/bin/slc7_amd64_gcc900/makeTrackValidationPlots.py", line 146, in <module>
    main(opts)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/bin/slc7_amd64_gcc900/makeTrackValidationPlots.py", line 76, in main
    val.doPlots(trk, plotterDrawArgs=drawArgs, **kwargs_tracking)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/validation.py", line 1260, in doPlots
    self._doPlotsForPlotter(plotter, sample, **kwargs)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/validation.py", line 1268, in _doPlotsForPlotter
    plotterInstance = plotter.readDirs(*self._openFiles)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/plotting.py", line 3011, in readDirs
    return PlotterInstance([plotterItem.readDirs(files) for plotterItem in self._plots])
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/plotting.py", line 3011, in <listcomp>
    return PlotterInstance([plotterItem.readDirs(files) for plotterItem in self._plots])
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/plotting.py", line 2930, in readDirs
    return PlotterFolder(self._name, self._possibleDirs, subFolders, self._plotFolder, self._fallbackNames, self._fallbackDqmSubFolders, self._tableCreators)
  File "/cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-08-2300/python/Validation/RecoTrack/plotting/plotting.py", line 2741, in __init__
    self._dqmSubFolders.sort(key=lambda sf: sf.subfolder)
AttributeError: 'dict_values' object has no attribute 'sort'
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

A new Issue was created by @VinInn Vincenzo Innocente.

@Dr15Jones, @perrotta, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@VinInn
Copy link
Contributor Author

VinInn commented Jul 9, 2021

@makortel @mtosi @vmariani

@mmusich
Copy link
Contributor

mmusich commented Jul 9, 2021

due to a558708 ?
@davidlange6

@makortel
Copy link
Contributor

makortel commented Jul 9, 2021

I'm taking a look. That particular issue is easy to fix, but there can be further issues.

@makortel
Copy link
Contributor

makortel commented Jul 9, 2021

assign dqm

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 9, 2021

New categories assigned: dqm

@jfernan2,@kmaeshima,@rvenditti,@andrius-k,@ErnestaP,@ahmad3213 you have been requested to review this Pull request/Issue and eventually sign? Thanks

@makortel
Copy link
Contributor

makortel commented Jul 9, 2021

Fixed in #34430.

@jfernan2
Copy link
Contributor

+1
For the records

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants