Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we remove EventInterpretation step out from relval? #32643

Closed
srimanob opened this issue Jan 12, 2021 · 18 comments
Closed

Should we remove EventInterpretation step out from relval? #32643

srimanob opened this issue Jan 12, 2021 · 18 comments

Comments

@srimanob
Copy link
Contributor

srimanob commented Jan 12, 2021

Since 10_6 (Legacy), we stop using EI step in the production. Do we still need it in Run-2/Run-3 relvals workflows? I've checked with

This is to reflect the "close-to-"real sequence using in production.

Any concerns from RECO @slava77 @jpata

@cmsbuild
Copy link
Contributor

A new Issue was created by @srimanob Phat Srimanobhas.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@makortel
Copy link
Contributor

assign reconstruction, pdmv, upgrade

@cmsbuild
Copy link
Contributor

New categories assigned: pdmv,upgrade,reconstruction

@slava77,@chayanit,@wajidalikhan,@perrotta,@jpata,@jordan-martins,@kpedro88,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks

@davidlange6
Copy link
Contributor

davidlange6 commented Jan 12, 2021 via email

@makortel
Copy link
Contributor

assign dqm

@cmsbuild
Copy link
Contributor

New categories assigned: dqm

@jfernan2,@andrius-k,@fioriNTU,@kmaeshima,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks

@jfernan2
Copy link
Contributor

@srimanob
Copy link
Contributor Author

srimanob commented Jan 12, 2021

Thanks, @jfernan2

If my memory is correct, the EI was introduced since long before PAT was still known as the analysis tool, not part of the central sequence. And there was an objection to validate PAT objects (as no central/agree obj). Cleaning objects were still analysis dependent job using the tool. I think if people want to validate the object nowadays, MiniAOD object is a good candidate as it is used for analysis, not EI object.

Maybe @rappoccio can comment as he implemented path in that time (base on TOP object, I think).

@rappoccio
Copy link
Contributor

There's still an argument for using some kind of lepton cleaning. MiniAOD doesn't do lepton cleaning by default either, so perhaps we could migrate the DQM modules that use it (like TOP) to do lepton cleaning on MiniAOD instead?

@rappoccio
Copy link
Contributor

To be clear, I agree that removing EI from the sequence is appropriate.

@jfernan2
Copy link
Contributor

Adding TOP DQM contact: @kuyoun

@slava77
Copy link
Contributor

slava77 commented Feb 11, 2021

Any concerns from RECO @slava77 @jpata

we removed it from the outputs AOD a while ago and the step is kept for DQM purposes.

@srimanob
Copy link
Contributor Author

Thanks @slava77

I think this answers to @chayanit @wajidalikhan @jordan-martins that we don't need EI step for MC production. Then up to Top DQM for considering on migration.

@jfernan2
Copy link
Contributor

ping @kuyoun

@jfernan2
Copy link
Contributor

Hi, since there is no response from TOP developers I am removing EI in: #36465

@srimanob
Copy link
Contributor Author

Thanks @jfernan2
I think when PR is merged and IB runs fine, we can close this opened issue.

@jfernan2
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

Thanks @jfernan2 I think when PR is merged and IB runs fine, we can close this opened issue.

@srimanob #36465 is now merged (sice a while): I think we can close this issue, isn't it? Please re-open if I misunderstood your previous comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants