-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we remove EventInterpretation step out from relval? #32643
Comments
A new Issue was created by @srimanob Phat Srimanobhas. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign reconstruction, pdmv, upgrade |
New categories assigned: pdmv,upgrade,reconstruction @slava77,@chayanit,@wajidalikhan,@perrotta,@jpata,@jordan-martins,@kpedro88,@srimanob you have been requested to review this Pull request/Issue and eventually sign? Thanks |
At least some of the dqm sequences still require it.. (eg, @standardDQM)
… On Jan 12, 2021, at 3:07 PM, Phat Srimanobhas ***@***.***> wrote:
Since 10_6 (Legacy), we stop using EI step in the production. Do we still need it in Run-2/Run-3 relvals workflows? I've checked with
• runTheMatrix.py -i all --ibeos -l 10801.0
• runTheMatrix.py -i all --ibeos -l 11650.0
and EI step is still there. This is to reflect the "close-to-"real sequence using in production.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
assign dqm |
New categories assigned: dqm @jfernan2,@andrius-k,@fioriNTU,@kmaeshima,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks |
For dqm sequences it seems only the Physics DQM require EI: |
Thanks, @jfernan2 If my memory is correct, the EI was introduced since long before PAT was still known as the analysis tool, not part of the central sequence. And there was an objection to validate PAT objects (as no central/agree obj). Cleaning objects were still analysis dependent job using the tool. I think if people want to validate the object nowadays, MiniAOD object is a good candidate as it is used for analysis, not EI object. Maybe @rappoccio can comment as he implemented path in that time (base on TOP object, I think). |
There's still an argument for using some kind of lepton cleaning. MiniAOD doesn't do lepton cleaning by default either, so perhaps we could migrate the DQM modules that use it (like TOP) to do lepton cleaning on MiniAOD instead? |
To be clear, I agree that removing EI from the sequence is appropriate. |
Adding TOP DQM contact: @kuyoun |
Thanks @slava77 I think this answers to @chayanit @wajidalikhan @jordan-martins that we don't need EI step for MC production. Then up to Top DQM for considering on migration. |
ping @kuyoun |
Hi, since there is no response from TOP developers I am removing EI in: #36465 |
Thanks @jfernan2 |
+1 |
Since 10_6 (Legacy), we stop using EI step in the production. Do we still need it in Run-2/Run-3 relvals workflows? I've checked with
and EI step is still there, e.g. in
https://github.com/cms-sw/cmssw/blob/master/Configuration/PyReleaseValidation/python/relval_steps.py#L3339
This is to reflect the "close-to-"real sequence using in production.
Any concerns from RECO @slava77 @jpata
The text was updated successfully, but these errors were encountered: