-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SonicTriton fails to link in UBSAN builds #32630
Comments
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign core, heterogeneous |
@kpedro88 Could you take a look? |
New categories assigned: heterogeneous,core @Dr15Jones,@smuzaffar,@makortel,@makortel,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks |
If I run this command: the only typeinfo lines are:
I'm not sure if or why RTTI would have been disabled when compiling Triton... I can't immediately find a setting that would be responsible for this. |
See: cms-sw/cmsdist#6547 |
@makortel I no longer see the errors in the build log for CMSSW_11_3_UBSAN_X_2021-01-12-2300, so I think this fix was successful. |
Which is interesting given that cms-sw/cmsdist#6547 was merged only in CMSSW_11_3_X_2021-01-13-1100. Not sure why the failure disappeared earlier :) |
+1 |
This issue is fully signed and ready to be closed. |
@makortel if you click on the "CMSDIST" tab in the "Commits" section of https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/ib/CMSSW_11_3_X for that IB, you can select the UBSAN version of cmsdist, which does include my PR. |
Ah right, and it went into the default IBs one cycle later. Thanks! |
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc7_amd64_gcc900/CMSSW_11_3_UBSAN_X_2021-01-08-2300/HeterogeneousCore/SonicTriton
UBSAN build needs to link directly to the libraries that define the above mentioned types (because of it using
dynamic_cast
).The text was updated successfully, but these errors were encountered: