Use [[deprecated]] to mark deprecated classes and functions

[Dr15Jones]

Both gcc 8.3+ and clang 9+ support the attrbute [[deprecated]]. We could use this to

• mark the legacy EDFilter, EDProducer, and EDAnalyzer legacy classes
• mark the EventSetupRecord::get calls which do not use an ESGetToken

These would likely generate a large number of warnings at first but would at least force pull requests to not use the deprecated items.

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[Dr15Jones]

assign core

[cmsbuild]

New categories assigned: core

@Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks

[Dr15Jones]

In order to avoid flooding the IBs with warnings, we could wrap the use of [[deprecated]] in a macro and make sure the macro is off during the IB builds but on during the pull request tests and when people build locally.

[makortel]

Being able to ignore these warnings in IBs is (also?) my main concern. In PR tests, what about code in files not touched by the PR? If we manage to ignore those, this would effectively mean that any change in an "offending" file would require a migration away (which could be ok, but would require a policy discussion first I suppose).

[makortel]

+1

This has been implemented.

[cmsbuild]

This issue is fully signed and ready to be closed.