Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revisit MuonServiceProxy: are separate consumes needed in beginRun and Event #28843

Open
slava77 opened this issue Jan 31, 2020 · 3 comments
Open

Comments

@slava77
Copy link
Contributor

slava77 commented Jan 31, 2020

Following
#28840 (comment)

Review implementation of the following to see if the MuonServiceProxy::update call can be safely moved to the event processing (::produce calls).

  • FastSimulation/MuonSimHitProducer/src/MuonSimHitProducer.cc
  • RecoMuon/TrackerSeedGenerator/plugins/TSGFromL2Muon.cc

If the update calls can be moved to just the event, the beginRun support for MuonServiceProxy can be dropped.

OTOH, perhaps by the time of the resolution of this issue the framework will consider handling both transitions in a more transparent way.

@dntaylor @Fedespring @cericeci

@slava77
Copy link
Contributor Author

slava77 commented Jan 31, 2020

assign reconstruction

@wddgit

@cmsbuild
Copy link
Contributor

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

A new Issue was created by @slava77 Slava Krutelyov.

@Dr15Jones, @smuzaffar, @silviodonato, @makortel, @davidlange6, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants