::getenv is not guaranteed to be thread safe

[Dr15Jones]

The POSIX and C standard state that muliple calls to ::getenv are not guaranteed to be thread safe. The C++ standard std::getenv is thread safe. We should change all uses of ::getenv in CMSSW to use std::getenv.

[Dr15Jones]

assign core, reconstruction, simulation, dam

[cmsbuild]

New categories assigned: core,reconstruction,simulation

@Dr15Jones,@smuzaffar,@mdhildreth,@slava77,@perrotta,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

[cmsbuild]

A new Issue was created by @Dr15Jones Chris Jones.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

[civanch]

@Dr15Jones , Geant4 has a lot of calls to environment in order to access data files. Should we inform Geant4 about this problem?

[Dr15Jones]

@civanch

Should we inform Geant4 about this problem?

That's probably a good idea.

[Dr15Jones]

#28117 changes all code for core.

[fabiocos]

@Dr15Jones @smuzaffar preparing a PR to change all the rest...

[Dr15Jones]

#28124 does the rest

[perrotta]

@Dr15Jones , I can still find three ::getenv in CMSSW after your #28117 and #28124, namely:

• two in CondCore/Utilities/bin/cmscond_authentication_manager.cpp
• one in OnlineDB/EcalCondDB/bin/cmsecal_write_offline_det_id.cpp

Were they just got forgotten, or maybe that code is not to be run multithread?

[Dr15Jones]

@perrotta given both are stand alone programs, they were going to cause a problem for cmsRun :).

[perrotta]

+1

• FIxed with Use std::getenv #28117 and turn getenv into std::getenv for all cmssw residual occurencies #28124

[civanch]

The issue is fixed in Geant4 10.6 in all classes related to CMS productions.

[civanch]

+1