-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that uniqueness of named bins is not spoiling HLT monitoring #25702
Comments
A new Issue was created by @fabiocos Fabio Cossutti. @davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign hlt |
New categories assigned: hlt @Martin-Grunewald,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@Martin-Grunewald @silviodonato @qliphy is this issue stil present? |
Looks resolved to me... |
Not sure which validation was performed, anyway the class has evolved quite a lot since the time of this issue. @silviodonato @qliphy unless you have a different advice, but given the answer of @Martin-Grunewald I would close this PR |
+1 |
In order to migrate to the newest ROOT where histograms with named bins are merged via the bin's name, not the index, some code updates were proposed to the HLT monitoring code in #25569.
Although technically working, it would be useful to validate the output of this move, ensuring that the obtained histograms are correct according to the original design.
The text was updated successfully, but these errors were encountered: