Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that uniqueness of named bins is not spoiling HLT monitoring #25702

Closed
fabiocos opened this issue Jan 18, 2019 · 8 comments
Closed

Verify that uniqueness of named bins is not spoiling HLT monitoring #25702

fabiocos opened this issue Jan 18, 2019 · 8 comments

Comments

@fabiocos
Copy link
Contributor

In order to migrate to the newest ROOT where histograms with named bins are merged via the bin's name, not the index, some code updates were proposed to the HLT monitoring code in #25569.
Although technically working, it would be useful to validate the output of this move, ensuring that the obtained histograms are correct according to the original design.

@cmsbuild
Copy link
Contributor

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@Martin-Grunewald,@fwyzard you have been requested to review this Pull request/Issue and eventually sign? Thanks

@Martin-Grunewald
Copy link
Contributor

@mtosi @gennai

@fabiocos
Copy link
Contributor Author

@Martin-Grunewald @silviodonato @qliphy is this issue stil present?

@Martin-Grunewald
Copy link
Contributor

Looks resolved to me...

@fabiocos
Copy link
Contributor Author

Not sure which validation was performed, anyway the class has evolved quite a lot since the time of this issue. @silviodonato @qliphy unless you have a different advice, but given the answer of @Martin-Grunewald I would close this PR

@silviodonato
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants