Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove canDeleteEarly feature of the framework #12932

Closed
Dr15Jones opened this issue Jan 13, 2016 · 8 comments
Closed

remove canDeleteEarly feature of the framework #12932

Dr15Jones opened this issue Jan 13, 2016 · 8 comments

Comments

@Dr15Jones
Copy link
Contributor

A long time ago we added a feature that let one say an Event data product could be deleted before the end of processing of the Event. No configuration outside of the framework unit tests make use of this feature.
This feature is dangerous since it requires exact knowledge of each module which may use the data product so the product is not deleted before those modules are run. For modules just getting the container directly the consumes call would be able to verify this. However, this fails if the container is associated with a Ref like instance. In that case we have no way to find such Refs nor know what modules might use them. When run with multiple threads such a Ref could be dereferenced at the exact same time the framework decides to delete the object.

@cmsbuild
Copy link
Contributor

A new Issue was created by @Dr15Jones (Chris Jones).

@davidlange6, @smuzaffar, @Degano, @davidlt, @Dr15Jones can you please review it and eventually sign/assign? Thanks.

Following commands in first line of a comment are recognized

  • +1|approve[d]|sign[ed]: L1/L2's to approve it
  • -1|reject[ed]: L1/L2's to reject it
  • assign <category>[,<category>[,...]]: L1/L2's to request signatures from other categories
  • unassign <category>[,<category>[,...]]: L1/L2's to remove signatures from other categories
  • hold: L1/all L2's/release manager to mark it as on hold
  • unhold: L1/user who put this PR on hold
  • merge: L1/release managers to merge this request

@Dr15Jones
Copy link
Contributor Author

assign core

@cmsbuild
Copy link
Contributor

New categories assigned: core

@Dr15Jones,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks

@slava77
Copy link
Contributor

slava77 commented Jan 13, 2016

In HI processing (likely also in HL-LHC pileup environment) the total memory used often has a large fraction (about a half, maybe) consumed by transient products. If we could use the canDeleteEarly feature there in a safe way, we could save on some needed resources.

@smuzaffar
Copy link
Contributor

@Dr15Jones , do we still want to remove this feature? Looks like it is now used in many places outside FW ( https://github.com/cms-sw/cmssw/search?q=canDeleteEarly&type=code )

@Dr15Jones
Copy link
Contributor Author

@makortel

@makortel
Copy link
Contributor

I think this issue can be closed in favor of #16481 .

@smuzaffar
Copy link
Contributor

closing it in favor of #16481

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants