diff --git a/DQM/HcalTasks/plugins/DigiTask.cc b/DQM/HcalTasks/plugins/DigiTask.cc index 3782c185b91f3..7b9daa4e19052 100644 --- a/DQM/HcalTasks/plugins/DigiTask.cc +++ b/DQM/HcalTasks/plugins/DigiTask.cc @@ -790,7 +790,7 @@ DigiTask::DigiTask(edm::ParameterSet const& ps) lumiCache->EvtCntLS == 1) { // Reset the bin for _cCapid_BadvsFEDvsLSmod60 at the beginning of each new LS for (std::vector::const_iterator it = _vhashFEDs.begin(); it != _vhashFEDs.end(); ++it) { HcalElectronicsId eid = HcalElectronicsId(*it); - _cCapid_BadvsFEDvsLSmod60.setBinContent(eid, _currentLS % 50, 0); + _cCapid_BadvsFEDvsLSmod60.setBinContent(eid, _currentLS % 60, 0); } } diff --git a/DQM/HcalTasks/plugins/HcalGPUComparisonTask.cc b/DQM/HcalTasks/plugins/HcalGPUComparisonTask.cc index 6a57cd01b7a9c..162266f0e2119 100644 --- a/DQM/HcalTasks/plugins/HcalGPUComparisonTask.cc +++ b/DQM/HcalTasks/plugins/HcalGPUComparisonTask.cc @@ -93,13 +93,14 @@ HcalGPUComparisonTask::HcalGPUComparisonTask(edm::ParameterSet const& ps) /* virtual */ void HcalGPUComparisonTask::_resetMonitors(hcaldqm::UpdateFreq uf) { DQTask::_resetMonitors(uf); } /* virtual */ void HcalGPUComparisonTask::_process(edm::Event const& e, edm::EventSetup const&) { - edm::Handle chbhe_ref; - edm::Handle chbhe_target; + auto const chbhe_ref = e.getHandle(tokHBHE_ref_); + auto const chbhe_target = e.getHandle(tokHBHE_target_); - if (!(e.getByToken(tokHBHE_ref_, chbhe_ref))) - _logger.dqmthrow("The CPU HBHERecHitCollection \"" + tagHBHE_ref_.encode() + "\" is not available"); - if (!(e.getByToken(tokHBHE_target_, chbhe_target))) - _logger.dqmthrow("The GPU HBHERecHitCollection \"" + tagHBHE_target_.encode() + "\" is not available"); + if (not(chbhe_ref.isValid() and chbhe_target.isValid())) { + edm::LogWarning("HcalGPUComparisonTask") + << "Either CPU or GPU RecHit Collection is unavailable, will not fill this event."; + return; + } auto lumiCache = luminosityBlockCache(e.getLuminosityBlock().index()); _currentLS = lumiCache->currentLS; @@ -115,7 +116,8 @@ HcalGPUComparisonTask::HcalGPUComparisonTask(edm::ParameterSet const& ps) if (mRecHitEnergy.find(did) == mRecHitEnergy.end()) mRecHitEnergy.insert(std::make_pair(did, energy)); else - edm::LogError("HcalDQM|RechitTask") << "Duplicate Rechit from the same HcalDetId"; + edm::LogError("HcalGPUComparisonTask") << "Duplicate Rechit from the same HcalDetId"; + ; } for (HBHERecHitCollection::const_iterator it = chbhe_target->begin(); it != chbhe_target->end(); ++it) { @@ -140,11 +142,19 @@ HcalGPUComparisonTask::HcalGPUComparisonTask(edm::ParameterSet const& ps) } mRecHitEnergy.erase(did); - } else - edm::LogError("HcalDQM|RechitTask") << "GPU Rechit id not found in CPU Rechit id collection"; + } else { + if (energy > 2.) + edm::LogError("HcalGPUComparisonTask") + << "Energetic GPU Rechit exist, but not reconstructed by CPU. DetId = " << did; + } + } + if (!mRecHitEnergy.empty()) { + for (auto const& rhpair : mRecHitEnergy) { + if (rhpair.second > 2.) + edm::LogError("HcalGPUComparisonTask") + << "Energetic CPU Rechit exist, but not reconstructed by GPU. DetId = " << rhpair.first; + } } - if (!mRecHitEnergy.empty()) - edm::LogError("HcalDQM|RechitTask") << "CPU Rechit id not found in GPU Rechit id collection"; } std::shared_ptr HcalGPUComparisonTask::globalBeginLuminosityBlock(edm::LuminosityBlock const& lb, diff --git a/DQM/Integration/python/clients/hcalgpu_dqm_sourceclient-live_cfg.py b/DQM/Integration/python/clients/hcalgpu_dqm_sourceclient-live_cfg.py index 0dd5cf010e661..ce4c84b1e9003 100644 --- a/DQM/Integration/python/clients/hcalgpu_dqm_sourceclient-live_cfg.py +++ b/DQM/Integration/python/clients/hcalgpu_dqm_sourceclient-live_cfg.py @@ -102,8 +102,8 @@ # New Style Modules #------------------------------------- oldsubsystem = subsystem -process.hcalGPUComparisonTask.tagHBHE_ref = "hltHbherecoFromGPU" -process.hcalGPUComparisonTask.tagHBHE_target = "hltHbherecoLegacy" +process.hcalGPUComparisonTask.tagHBHE_ref = "hltHbherecoLegacy" +process.hcalGPUComparisonTask.tagHBHE_target = "hltHbherecoFromGPU" process.hcalGPUComparisonTask.runkeyVal = runType process.hcalGPUComparisonTask.runkeyName = runTypeName