From a1d52b9f51eb4a1a072867e60fc8931c60b2116d Mon Sep 17 00:00:00 2001
From: Shahzad Malik Muzaffar <Shahzad.Malik.Muzaffar@cern.ch>
Date: Wed, 15 Apr 2020 11:45:38 +0200
Subject: [PATCH] [PY3] Fix duplicate dictionary checker for python3

---
 Utilities/ReleaseScripts/scripts/XML2Python.py      |  2 +-
 .../scripts/duplicateReflexLibrarySearch.py         | 13 +++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/Utilities/ReleaseScripts/scripts/XML2Python.py b/Utilities/ReleaseScripts/scripts/XML2Python.py
index 707f135b17728..b2c05c30c20c4 100755
--- a/Utilities/ReleaseScripts/scripts/XML2Python.py
+++ b/Utilities/ReleaseScripts/scripts/XML2Python.py
@@ -101,7 +101,7 @@ def root (self):
 
     def topLevel (self):
         '''Returns top level object'''
-        return self._root.attributes().values()[0]
+        return list(self._root.attributes().values())[0]
         
 
     @staticmethod
diff --git a/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py b/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py
index 93debc5b35cf5..137d3f2b9c987 100755
--- a/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py
+++ b/Utilities/ReleaseScripts/scripts/duplicateReflexLibrarySearch.py
@@ -3,15 +3,16 @@
 from __future__ import print_function
 import optparse
 import os
-import commands
 import re
 import sys
 import pprint
-import commands
 import subprocess
 from XML2Python import xml2obj
 import six
-
+try:
+  from subprocess import getoutput
+except:
+  from commands import getoutput
 # These aren't all typedefs, but can sometimes make the output more
 # readable
 typedefsDict = \
@@ -98,7 +99,7 @@ def searchClassDefXml ():
     xmlFiles = []
     for srcDir in [os.environ.get('CMSSW_BASE'),os.environ.get('CMSSW_RELEASE_BASE')]:
         if not len(srcDir): continue
-        for xml in commands.getoutput ('cd '+os.path.join(srcDir,'src')+'; find . -name "*classes_def*.xml" -follow -print').split ('\n'):
+        for xml in getoutput ('cd '+os.path.join(srcDir,'src')+'; find . -name "*classes_def*.xml" -follow -print').split ('\n'):
             if xml and (not xml in xmlFiles):
                 xmlFiles.append(xml)
     if options.showXMLs:
@@ -255,12 +256,12 @@ def searchDuplicatePlugins ():
         if os.path.exists(libdir+'/.edmplugincache'): edmpluginFile = edmpluginFile + ' ' + libdir+'/.edmplugincache'
     if edmpluginFile == '': edmpluginFile = os.path.join(os.environ.get('CMSSW_BASE'),'lib',os.environ.get('SCRAM_ARCH'),'.edmplugincache')
     cmd = "cat %s | awk '{print $2\" \"$1}' | sort | uniq | awk '{print $1}' | sort | uniq -c | grep '2 ' | awk '{print $2}'" % edmpluginFile
-    output = commands.getoutput (cmd).split('\n')
+    output = getoutput (cmd).split('\n')
     for line in output:
         if line in ignoreEdmDP: continue
         line = line.replace("*","\*")
         cmd = "cat %s | grep ' %s ' | awk '{print $1}' | sort | uniq " % (edmpluginFile,line)
-        out1 = commands.getoutput (cmd).split('\n')
+        out1 = getoutput (cmd).split('\n')
         print(line)
         for plugin in out1:
             if plugin: