From 7add316de292eb7bedb44b39d1bfc2a99688803b Mon Sep 17 00:00:00 2001 From: Marcel Andre Schneider Date: Thu, 7 Nov 2019 16:42:57 +0100 Subject: [PATCH] Depend on *all* DQMTokens. This is stupid and wrong, but actually works. --- DQM/SiStripMonitorClient/plugins/SiStripOfflineDQM.cc | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/DQM/SiStripMonitorClient/plugins/SiStripOfflineDQM.cc b/DQM/SiStripMonitorClient/plugins/SiStripOfflineDQM.cc index 84e8677f91393..51233256f7bc6 100644 --- a/DQM/SiStripMonitorClient/plugins/SiStripOfflineDQM.cc +++ b/DQM/SiStripMonitorClient/plugins/SiStripOfflineDQM.cc @@ -68,8 +68,11 @@ SiStripOfflineDQM::SiStripOfflineDQM(edm::ParameterSet const& pSet) // explicit dependency to make sure the QTest reults needed here are present // already in endRun. - consumes(edm::InputTag("siStripQTester")); - consumes(edm::InputTag("siStripQTester")); + // TODO: this should only read the one Token needed, not all. Otherwise we'd + // get a cyclic dependency if this module produces DQMTokens itself. This + // would happen e.g. if this was a DQMEDHarvester, as it should be. + consumesMany(); + consumesMany(); usesResource("DQMStore"); }