diff --git a/DQM/EcalMonitorClient/interface/TimingClient.h b/DQM/EcalMonitorClient/interface/TimingClient.h index ecd5ce694128f..a9aa5f4352adb 100644 --- a/DQM/EcalMonitorClient/interface/TimingClient.h +++ b/DQM/EcalMonitorClient/interface/TimingClient.h @@ -15,8 +15,8 @@ namespace ecaldqm { private: void setParams(edm::ParameterSet const&) override; - float EBtoleranceMean_; - float EEtoleranceMean_; + float ebtoleranceMean_; + float eetoleranceMean_; float toleranceMeanFwd_; float toleranceRMS_; float toleranceRMSFwd_; diff --git a/DQM/EcalMonitorClient/python/TimingClient_cfi.py b/DQM/EcalMonitorClient/python/TimingClient_cfi.py index 785e2ae41e6f7..686e3ff3c232b 100644 --- a/DQM/EcalMonitorClient/python/TimingClient_cfi.py +++ b/DQM/EcalMonitorClient/python/TimingClient_cfi.py @@ -5,8 +5,8 @@ minChannelEntries = 1 minTowerEntries = 3 -EBtoleranceMean = 2. -EEtoleranceMean = 3. +ebtoleranceMean = 2. +eetoleranceMean = 3. toleranceRMS = 6. minChannelEntriesFwd = 8 minTowerEntriesFwd = 24 @@ -19,8 +19,8 @@ params = cms.untracked.PSet( minChannelEntries = cms.untracked.int32(minChannelEntries), minTowerEntries = cms.untracked.int32(minTowerEntries), - EBtoleranceMean = cms.untracked.double(EBtoleranceMean), - EEtoleranceMean = cms.untracked.double(EEtoleranceMean), + ebtoleranceMean = cms.untracked.double(ebtoleranceMean), + eetoleranceMean = cms.untracked.double(eetoleranceMean), toleranceRMS = cms.untracked.double(toleranceRMS), minChannelEntriesFwd = cms.untracked.int32(minChannelEntriesFwd), minTowerEntriesFwd = cms.untracked.int32(minTowerEntriesFwd), @@ -129,14 +129,14 @@ kind = cms.untracked.string('TH2F'), otype = cms.untracked.string('Ecal3P'), btype = cms.untracked.string('SuperCrystal'), - description = cms.untracked.string('Summary of the timing data quality. A 5x5 tower is red if the mean timing of the tower is off by more than ' + str(EBtoleranceMean) + 'for EB and ' + str(EEtoleranceMean) + 'for EE, or RMS is greater than ' + str(toleranceRMS) + ' (' + str(toleranceMeanFwd) + ' and ' + str(toleranceRMSFwd) + ' in forward region). Towers with total entries less than ' + str(minTowerEntries) + ' are not subject to this evaluation. Since 5x5 tower timings are calculated with a tighter time-window than per-channel timings, a tower can additionally become red if its the sum of per-channel timing histogram entries is greater than per-tower histogram entries by factor ' + str(1. / (1. - tailPopulThreshold)) + ' (significant fraction of events fall outside the tight time-window).') + description = cms.untracked.string('Summary of the timing data quality. A 5x5 tower is red if the mean timing of the tower is off by more than ' + str(ebtoleranceMean) + 'for EB and ' + str(eetoleranceMean) + 'for EE, or RMS is greater than ' + str(toleranceRMS) + ' (' + str(toleranceMeanFwd) + ' and ' + str(toleranceRMSFwd) + ' in forward region). Towers with total entries less than ' + str(minTowerEntries) + ' are not subject to this evaluation. Since 5x5 tower timings are calculated with a tighter time-window than per-channel timings, a tower can additionally become red if its the sum of per-channel timing histogram entries is greater than per-tower histogram entries by factor ' + str(1. / (1. - tailPopulThreshold)) + ' (significant fraction of events fall outside the tight time-window).') ), Quality = cms.untracked.PSet( path = cms.untracked.string('%(subdet)s/%(prefix)sTimingClient/%(prefix)sTMT timing quality %(sm)s'), kind = cms.untracked.string('TH2F'), otype = cms.untracked.string('SM'), btype = cms.untracked.string('Crystal'), - description = cms.untracked.string('Summary of the timing data quality. A channel is red if its mean timing is off by more than ' + str(EBtoleranceMean) + 'for EB and' + str(EEtoleranceMean) + 'for EE, or RMS is greater than ' + str(toleranceRMS) + '. Channels with entries less than ' + str(minChannelEntries) + ' are not considered.') + description = cms.untracked.string('Summary of the timing data quality. A channel is red if its mean timing is off by more than ' + str(ebtoleranceMean) + 'for EB and' + str(eetoleranceMean) + 'for EE, or RMS is greater than ' + str(toleranceRMS) + '. Channels with entries less than ' + str(minChannelEntries) + ' are not considered.') ), MeanAll = cms.untracked.PSet( path = cms.untracked.string('%(subdet)s/%(prefix)sSummaryClient/%(prefix)sTMT%(suffix)s timing mean 1D summary'), diff --git a/DQM/EcalMonitorClient/src/TimingClient.cc b/DQM/EcalMonitorClient/src/TimingClient.cc index 5302215c3ebf5..9ffe00b56cad1 100644 --- a/DQM/EcalMonitorClient/src/TimingClient.cc +++ b/DQM/EcalMonitorClient/src/TimingClient.cc @@ -12,8 +12,8 @@ namespace ecaldqm { TimingClient::TimingClient() : DQWorkerClient(), - EBtoleranceMean_(0.), - EEtoleranceMean_(0.), + ebtoleranceMean_(0.), + eetoleranceMean_(0.), toleranceMeanFwd_(0.), toleranceRMS_(0.), toleranceRMSFwd_(0.), @@ -27,8 +27,8 @@ namespace ecaldqm { } void TimingClient::setParams(edm::ParameterSet const& _params) { - EBtoleranceMean_ = _params.getUntrackedParameter("EBtoleranceMean"); - EEtoleranceMean_ = _params.getUntrackedParameter("EEtoleranceMean"); + ebtoleranceMean_ = _params.getUntrackedParameter("ebtoleranceMean"); + eetoleranceMean_ = _params.getUntrackedParameter("eetoleranceMean"); toleranceMeanFwd_ = _params.getUntrackedParameter("toleranceMeanFwd"); toleranceRMS_ = _params.getUntrackedParameter("toleranceRMS"); toleranceRMSFwd_ = _params.getUntrackedParameter("toleranceRMSFwd"); @@ -79,9 +79,9 @@ namespace ecaldqm { float rmsThresh(toleranceRMS_); if (id.subdetId() == EcalBarrel) - meanThresh = EBtoleranceMean_; + meanThresh = ebtoleranceMean_; else - meanThresh = EEtoleranceMean_; + meanThresh = eetoleranceMean_; if (isForward(id)) { minChannelEntries = minChannelEntriesFwd_; @@ -196,9 +196,9 @@ namespace ecaldqm { float rmsThresh(toleranceRMS_); if (tId.subdetId() == EcalBarrel) - meanThresh = EBtoleranceMean_; + meanThresh = ebtoleranceMean_; else - meanThresh = EEtoleranceMean_; + meanThresh = eetoleranceMean_; if (isForward(tId)) { minTowerEntries = minTowerEntriesFwd_;