From 43ae8439e5b5e55b06569a16edf34091dc47b16c Mon Sep 17 00:00:00 2001 From: Dinko Ferencek Date: Tue, 26 Sep 2023 11:42:44 +0200 Subject: [PATCH 1/2] skip the 2nd error word for the timeout error as in the CPU code --- .../SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu | 1 + 1 file changed, 1 insertion(+) diff --git a/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu b/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu index e1b2964b4be84..ea2cfb044decc 100644 --- a/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu +++ b/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu @@ -212,6 +212,7 @@ namespace pixelgpudetails { if (!((errorWord >> sipixelconstants::OMIT_ERR_shift) & sipixelconstants::OMIT_ERR_mask)) { if constexpr (debug) printf("...2nd errorType=29 error, skip\n"); + break; } errorFound = true; break; From ccb05e6c6584aaf776462c6affb7bb3811de1e1c Mon Sep 17 00:00:00 2001 From: Dinko Ferencek Date: Tue, 26 Sep 2023 11:48:31 +0200 Subject: [PATCH 2/2] store errors only for valid DetIds --- .../SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu b/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu index ea2cfb044decc..39be1188e6c68 100644 --- a/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu +++ b/RecoLocalTracker/SiPixelClusterizer/plugins/SiPixelRawToClusterGPUKernel.cu @@ -324,7 +324,8 @@ namespace pixelgpudetails { skipROC = (roc < pixelgpudetails::maxROCIndex) ? false : (errorType != 0); if (includeErrors and skipROC) { uint32_t rID = getErrRawID(fedId, ww, errorType, cablingMap); - err->push_back(SiPixelErrorCompact{rID, ww, errorType, fedId}); + if (rID != 0xffffffff) // store errors only for valid DetIds + err->push_back(SiPixelErrorCompact{rID, ww, errorType, fedId}); continue; }