diff --git a/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByChi2Impl.cc b/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByChi2Impl.cc index fff2cef320fd7..5955220012b8d 100644 --- a/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByChi2Impl.cc +++ b/SimTracker/TrackAssociatorProducers/plugins/TrackAssociatorByChi2Impl.cc @@ -81,7 +81,7 @@ SimToRecoCollection TrackAssociatorByChi2Impl::associateSimToReco( const edm::RefToBaseVector& tC, const edm::RefVector& tPCH) const { const reco::BeamSpot& bs = *theBeamSpot; - SimToRecoCollection outputCollection(productGetter_); + SimToRecoCollection outputCollection(productGetter_); int tpindex = 0; for (auto tp = tPCH.begin(); tp != tPCH.end(); tp++, ++tpindex) { diff --git a/Validation/RecoTrack/interface/MTVHistoProducerAlgoForTracker.h b/Validation/RecoTrack/interface/MTVHistoProducerAlgoForTracker.h index a6f14601e807d..9fb9096a82f4a 100644 --- a/Validation/RecoTrack/interface/MTVHistoProducerAlgoForTracker.h +++ b/Validation/RecoTrack/interface/MTVHistoProducerAlgoForTracker.h @@ -129,7 +129,8 @@ struct MTVHistoProducerAlgoForTrackerHistograms { //chi2 and # lost hits vs eta: to be used with doProfileX std::vector chi2_vs_eta, chi2_vs_pt, chi2_vs_drj, nlosthits_vs_eta; - std::vector assoc_chi2_vs_eta, assoc_chi2_vs_pt, assoc_chi2_vs_drj, assoc_chi2prob_vs_eta, assoc_chi2prob_vs_pt, assoc_chi2prob_vs_drj; + std::vector assoc_chi2_vs_eta, assoc_chi2_vs_pt, assoc_chi2_vs_drj, assoc_chi2prob_vs_eta, + assoc_chi2prob_vs_pt, assoc_chi2prob_vs_drj; //resolution of track params: to be used with fitslicesytool std::vector dxyres_vs_eta, ptres_vs_eta, dzres_vs_eta, phires_vs_eta, cotThetares_vs_eta; diff --git a/Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc b/Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc index be9d60d9f58d0..25445455edac1 100644 --- a/Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc +++ b/Validation/RecoTrack/src/MTVHistoProducerAlgoForTracker.cc @@ -1099,8 +1099,8 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, ibook.bookProfile("chi2mean_vs_phi", "mean #chi^{2} vs #phi", nintPhi, minPhi, maxPhi, 200, 0, 20, " ")); histograms.chi2_vs_pt.push_back( makeProfileIfLogX(ibook, useLogPt, "chi2mean_vs_pt", "mean #chi^{2} vs p_{T}", nintPt, minPt, maxPt, 0, 20)); - histograms.chi2_vs_drj.push_back( - makeProfileIfLogX(ibook, true,"chi2mean_vs_drj","mean #chi^{2} vs dR(track,jet)",nintdrj,log10(mindrj),log10(maxdrj), 0, 20)); + histograms.chi2_vs_drj.push_back(makeProfileIfLogX( + ibook, true, "chi2mean_vs_drj", "mean #chi^{2} vs dR(track,jet)", nintdrj, log10(mindrj), log10(maxdrj), 0, 20)); histograms.assoc_chi2_vs_eta.push_back( ibook.bookProfile("assoc_chi2mean", "mean #chi^{2} vs #eta", nintEta, minEta, maxEta, 200, 0., 20., " ")); @@ -1110,10 +1110,24 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, ibook, useLogPt, "assoc_chi2mean_vs_pt", "mean #chi^{2} vs p_{T}", nintPt, minPt, maxPt, 0., 20.)); histograms.assoc_chi2prob_vs_pt.push_back(makeProfileIfLogX( ibook, useLogPt, "assoc_chi2prob_vs_pt", "mean #chi^{2} probability vs p_{T}", nintPt, minPt, maxPt, 0., 1.)); - histograms.assoc_chi2_vs_drj.push_back(makeProfileIfLogX( - ibook, true,"assoc_chi2mean_vs_drj","mean #chi^{2} vs dR(track,jet)",nintdrj,log10(mindrj),log10(maxdrj), 0., 20)); - histograms.assoc_chi2prob_vs_drj.push_back(makeProfileIfLogX( - ibook, true,"assoc_chi2prob_vs_drj","mean #chi^{2} probability vs dR(track,jet)",nintdrj,log10(mindrj),log10(maxdrj), 0., 1.)); + histograms.assoc_chi2_vs_drj.push_back(makeProfileIfLogX(ibook, + true, + "assoc_chi2mean_vs_drj", + "mean #chi^{2} vs dR(track,jet)", + nintdrj, + log10(mindrj), + log10(maxdrj), + 0., + 20)); + histograms.assoc_chi2prob_vs_drj.push_back(makeProfileIfLogX(ibook, + true, + "assoc_chi2prob_vs_drj", + "mean #chi^{2} probability vs dR(track,jet)", + nintdrj, + log10(mindrj), + log10(maxdrj), + 0., + 1.)); histograms.nhits_vs_eta.push_back( ibook.bookProfile("hits_eta", "mean hits vs eta", nintEta, minEta, maxEta, nintHit, minHit, maxHit, " ")); @@ -1394,15 +1408,15 @@ void MTVHistoProducerAlgoForTracker::bookRecoHistos(DQMStore::IBooker& ibook, bookResolutionPlots2D( histograms.thetapull_vs_eta, false, "thetapull_vs_eta", "thetapull_vs_eta", nintEta, minEta, maxEta, 100, -10, 10); bookResolutionPlots2D( - histograms.dxypull_vs_pt, useLogPt, "dxypull_vs_pt","dxypull_vs_pt",nintPt,minPt,maxPt,100,-10,10); + histograms.dxypull_vs_pt, useLogPt, "dxypull_vs_pt", "dxypull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); bookResolutionPlots2D( - histograms.ptpull_vs_pt, useLogPt, "ptpull_vs_pt","ptpull_vs_pt",nintPt,minPt,maxPt,100,-10,10); + histograms.ptpull_vs_pt, useLogPt, "ptpull_vs_pt", "ptpull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); bookResolutionPlots2D( - histograms.dzpull_vs_pt, useLogPt, "dzpull_vs_pt","dzpull_vs_pt",nintPt,minPt,maxPt,100,-10,10); + histograms.dzpull_vs_pt, useLogPt, "dzpull_vs_pt", "dzpull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); bookResolutionPlots2D( - histograms.phipull_vs_pt, useLogPt, "phipull_vs_pt","phipull_vs_pt",nintPt,minPt,maxPt,100,-10,10); + histograms.phipull_vs_pt, useLogPt, "phipull_vs_pt", "phipull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); bookResolutionPlots2D( - histograms.thetapull_vs_pt, useLogPt, "thetapull_vs_pt","thetapull_vs_pt",nintPt,minPt,maxPt,100,-10,10); + histograms.thetapull_vs_pt, useLogPt, "thetapull_vs_pt", "thetapull_vs_pt", nintPt, minPt, maxPt, 100, -10, 10); // histograms.h_ptshiftetamean.push_back( ibook.book1D("h_ptshifteta_Mean","<#deltapT/pT>[%] vs #eta",nintEta,minEta,maxEta) ); @@ -2042,7 +2056,7 @@ void MTVHistoProducerAlgoForTracker::fill_generic_recoTrack_histos(const Histogr histograms.h_recozpos[count]->Fill(vertz); histograms.h_recodr[count]->Fill(dR); histograms.h_recodrj[count]->Fill(dRJet); - histograms.chi2_vs_drj[count]->Fill(dRJet,chi2); + histograms.chi2_vs_drj[count]->Fill(dRJet, chi2); if (fillSeedingLayerSets) histograms.h_reco_seedingLayerSet[count]->Fill(seedingLayerSetBin); if (pvPosition) { @@ -2499,7 +2513,7 @@ void MTVHistoProducerAlgoForTracker::fill_ResoAndPull_recoTrack_histos(const His histograms.dzpull_vs_eta[count]->Fill(etaSim, dzPull); histograms.phipull_vs_eta[count]->Fill(etaSim, phiPull); histograms.thetapull_vs_eta[count]->Fill(etaSim, thetaPull); - + //pulls of track params vs pt: fill 2D histos histograms.dxypull_vs_pt[count]->Fill(ptSim, dxyPull); histograms.ptpull_vs_pt[count]->Fill(ptSim, ptres / ptError);