diff --git a/RecoHGCal/TICL/plugins/TrackstersProducer.cc b/RecoHGCal/TICL/plugins/TrackstersProducer.cc index 14345ffedde9e..085955d0d649b 100644 --- a/RecoHGCal/TICL/plugins/TrackstersProducer.cc +++ b/RecoHGCal/TICL/plugins/TrackstersProducer.cc @@ -102,9 +102,9 @@ TrackstersProducer::TrackstersProducer(const edm::ParameterSet& ps, const Tracks iterIndex_ = ticl::Trackster::TRKEM; else if (itername_ == "EM") iterIndex_ = ticl::Trackster::EM; - else if (itername_ == "TRK") + else if (itername_ == "TrkHAD") iterIndex_ = ticl::Trackster::TRKHAD; - else if (itername_ == "HADRONIC") + else if (itername_ == "HAD") iterIndex_ = ticl::Trackster::HAD; else if (itername_ == "MIP") iterIndex_ = ticl::Trackster::MIP; diff --git a/RecoHGCal/TICL/python/HADStep_cff.py b/RecoHGCal/TICL/python/HADStep_cff.py index 9af07d2e4faf4..655fadae45f3a 100644 --- a/RecoHGCal/TICL/python/HADStep_cff.py +++ b/RecoHGCal/TICL/python/HADStep_cff.py @@ -30,7 +30,7 @@ min_cos_theta = 0.866, # ~30 degrees min_cos_pointing = 0.819, # ~35 degrees max_delta_time = -1, - itername = "HADRONIC" + itername = "HAD" ) # MULTICLUSTERS diff --git a/RecoHGCal/TICL/python/TrkStep_cff.py b/RecoHGCal/TICL/python/TrkStep_cff.py index 739a7cafd5d2b..32103badd3604 100644 --- a/RecoHGCal/TICL/python/TrkStep_cff.py +++ b/RecoHGCal/TICL/python/TrkStep_cff.py @@ -32,7 +32,7 @@ algo_verbosity = 2, oneTracksterPerTrackSeed = True, promoteEmptyRegionToTrackster = True, - itername = "TRK" + itername = "TrkHAD" ) # MULTICLUSTERS diff --git a/RecoHGCal/TICL/python/iterativeTICL_cff.py b/RecoHGCal/TICL/python/iterativeTICL_cff.py index 9c961d580d09e..10af6c9fc2293 100644 --- a/RecoHGCal/TICL/python/iterativeTICL_cff.py +++ b/RecoHGCal/TICL/python/iterativeTICL_cff.py @@ -22,14 +22,20 @@ pfTICL = _pfTICLProducer.clone() ticlPFTask = cms.Task(pfTICL) -iterTICLTask = cms.Task(ticlLayerTileTask - ,ticlTrkEMStepTask +ticlIterations = cms.Task( + ticlTrkEMStepTask ,ticlEMStepTask ,ticlTrkStepTask ,ticlHADStepTask +) +ticlIterLabels = [_step.itername.value() for _iteration in ticlIterations for _step in _iteration if (_step._TypedParameterizable__type == "TrackstersProducer")] + +iterTICLTask = cms.Task(ticlLayerTileTask + ,ticlIterations ,ticlTracksterMergeTask ,ticlPFTask - ) +) +ticlIterLabelsMerge = ticlIterLabels + ["Merge"] ticlLayerTileHFNose = ticlLayerTileProducer.clone( detector = 'HFNose' diff --git a/Validation/HGCalValidation/python/HGCalValidator_cfi.py b/Validation/HGCalValidation/python/HGCalValidator_cfi.py index 8a6925bcb1f6d..55a0a40f53c1e 100644 --- a/Validation/HGCalValidation/python/HGCalValidator_cfi.py +++ b/Validation/HGCalValidation/python/HGCalValidator_cfi.py @@ -7,6 +7,12 @@ from SimCalorimetry.HGCalAssociatorProducers.LCToSCAssociation_cfi import layerClusterSimClusterAssociation from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer + +from RecoHGCal.TICL.iterativeTICL_cff import ticlIterLabels, ticlIterLabelsMerge + +labelMcl = [cms.InputTag("ticlMultiClustersFromTracksters"+iteration) for iteration in ticlIterLabelsMerge] +lcInputMask = [cms.InputTag("ticlTracksters"+iteration) for iteration in ticlIterLabels] + hgcalValidator = DQMEDAnalyzer( "HGCalValidator", @@ -17,12 +23,7 @@ ### reco input configuration ### #2dlayerclusters, pfclusters, multiclusters label_lcl = layerClusterCaloParticleAssociation.label_lc, - label_mcl = cms.VInputTag( - cms.InputTag("ticlMultiClustersFromTrackstersTrk"), - cms.InputTag("ticlMultiClustersFromTrackstersTrkEM"), - cms.InputTag("ticlMultiClustersFromTrackstersEM"), - cms.InputTag("ticlMultiClustersFromTrackstersHAD"), - cms.InputTag("ticlMultiClustersFromTrackstersMerge")), + label_mcl = cms.VInputTag(labelMcl), associator = cms.untracked.InputTag("layerClusterCaloParticleAssociationProducer"), @@ -54,12 +55,7 @@ simVertices = cms.InputTag("g4SimHits"), - LayerClustersInputMask = cms.VInputTag( - cms.InputTag("ticlTrackstersTrkEM"), - cms.InputTag("ticlTrackstersEM"), - cms.InputTag("ticlTrackstersTrk"), - cms.InputTag("ticlTrackstersHAD") - ), + LayerClustersInputMask = cms.VInputTag(lcInputMask), #Total number of layers of HGCal that we want to monitor #Could get this also from HGCalImagingAlgo::maxlayer but better to get it from here diff --git a/Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py b/Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py index 495e05e91d9a9..7d5d07a6c07f2 100644 --- a/Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py +++ b/Validation/HGCalValidation/python/PostProcessorHGCAL_cfi.py @@ -1,5 +1,6 @@ import FWCore.ParameterSet.Config as cms from DQMServices.Core.DQMEDHarvester import DQMEDHarvester +from RecoHGCal.TICL.iterativeTICL_cff import ticlIterLabelsMerge maxlayerzm = 50# last layer of BH -z maxlayerzp = 100# last layer of BH +z @@ -33,14 +34,9 @@ eff_simclusters.extend(["merge_eta_layer{:02d} 'LayerCluster Merge Rate vs #eta Layer{:02d} in z-' NumMerge_LayerCluster_in_SimCluster_Eta_perlayer{:02d} Denom_LayerCluster_in_SimCluster_Eta_perlayer{:02d}".format(i, i%maxlayerzm+1, i, i) if (i