From 0882bffac2e9a8dd647d02e057490a6b9aa74396 Mon Sep 17 00:00:00 2001 From: Abhirami Harilal Date: Thu, 11 Jul 2024 16:07:53 +0200 Subject: [PATCH 1/2] Disable quality cuts on LED quality plot --- DQM/EcalMonitorClient/src/LedClient.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/DQM/EcalMonitorClient/src/LedClient.cc b/DQM/EcalMonitorClient/src/LedClient.cc index 6068723eed63f..057ac37670496 100644 --- a/DQM/EcalMonitorClient/src/LedClient.cc +++ b/DQM/EcalMonitorClient/src/LedClient.cc @@ -165,6 +165,10 @@ namespace ecaldqm { float aRmsThr(sqrt(pow(aMean * toleranceAmpRMSRatio_, 2) + pow(3., 2))); + //Temporarily disabling all cuts on LED Quality plot. + qItr->setBinContent(doMask ? kMGood : kGood); + + /* EcalScDetId scid = EEDetId(id).sc(); //Get the Endcap SC id for the given crystal id. //For the known bad Supercrystals in the SClist, bad quality flag is only set based on the amplitude RMS @@ -180,7 +184,7 @@ namespace ecaldqm { qItr->setBinContent(doMask ? kMBad : kBad); else qItr->setBinContent(doMask ? kMGood : kGood); - } + }*/ } towerAverage_(meQualitySummary, meQuality, 0.2); From a3bef8cd927d55b531fba5c6f26a7ccb6119bc73 Mon Sep 17 00:00:00 2001 From: Abhirami Harilal Date: Thu, 11 Jul 2024 16:08:37 +0200 Subject: [PATCH 2/2] Change FEStatus quality threshold --- DQM/EcalMonitorClient/interface/RawDataClient.h | 2 +- DQM/EcalMonitorClient/python/RawDataClient_cfi.py | 4 +++- DQM/EcalMonitorClient/src/RawDataClient.cc | 5 +++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/DQM/EcalMonitorClient/interface/RawDataClient.h b/DQM/EcalMonitorClient/interface/RawDataClient.h index c1749e7d2a098..163ca607d3159 100644 --- a/DQM/EcalMonitorClient/interface/RawDataClient.h +++ b/DQM/EcalMonitorClient/interface/RawDataClient.h @@ -14,7 +14,7 @@ namespace ecaldqm { private: void setParams(edm::ParameterSet const&) override; - + int minEvents_; float synchErrThresholdFactor_; }; diff --git a/DQM/EcalMonitorClient/python/RawDataClient_cfi.py b/DQM/EcalMonitorClient/python/RawDataClient_cfi.py index c495403f01195..4e95f1a219ad5 100644 --- a/DQM/EcalMonitorClient/python/RawDataClient_cfi.py +++ b/DQM/EcalMonitorClient/python/RawDataClient_cfi.py @@ -4,9 +4,11 @@ from DQM.EcalMonitorTasks.RawDataTask_cfi import ecalRawDataTask synchErrThresholdFactor = 1. +minEvents = 400 ecalRawDataClient = cms.untracked.PSet( params = cms.untracked.PSet( + minEvents = cms.untracked.int32(minEvents), synchErrThresholdFactor = cms.untracked.double(synchErrThresholdFactor) ), sources = cms.untracked.PSet( @@ -20,7 +22,7 @@ kind = cms.untracked.string('TH2F'), otype = cms.untracked.string('Ecal3P'), btype = cms.untracked.string('SuperCrystal'), - description = cms.untracked.string('Summary of the raw data (DCC and front-end) quality. A channel is red if it has nonzero events with FE status that is different from any of ENABLED, DISABLED, SUPPRESSED, FIFOFULL, FIFOFULL_L1ADESYNC, and FORCEDZS. A FED can also go red if its number of L1A desynchronization errors is greater than ' + str(synchErrThresholdFactor) + ' * log10(total entries).') + description = cms.untracked.string('Summary of the raw data (DCC and front-end) quality. A channel is red if it has '+ str(minEvents)+' or more events with FE status that is different from any of ENABLED, DISABLED, SUPPRESSED, FIFOFULL, FIFOFULL_L1ADESYNC, and FORCEDZS. A FED can also go red if its number of L1A desynchronization errors is greater than ' + str(synchErrThresholdFactor) + ' * log10(total entries).') ), ErrorsSummary = cms.untracked.PSet( path = cms.untracked.string('%(subdet)s/%(prefix)sSummaryClient/%(prefix)sSFT front-end status errors summary'), diff --git a/DQM/EcalMonitorClient/src/RawDataClient.cc b/DQM/EcalMonitorClient/src/RawDataClient.cc index df34d80f294be..76e233f66a7b0 100644 --- a/DQM/EcalMonitorClient/src/RawDataClient.cc +++ b/DQM/EcalMonitorClient/src/RawDataClient.cc @@ -11,11 +11,12 @@ namespace ecaldqm { - RawDataClient::RawDataClient() : DQWorkerClient(), synchErrThresholdFactor_(0.) { + RawDataClient::RawDataClient() : DQWorkerClient(), minEvents_(0), synchErrThresholdFactor_(0.) { qualitySummaries_.insert("QualitySummary"); } void RawDataClient::setParams(edm::ParameterSet const& _params) { + minEvents_ = _params.getUntrackedParameter("minEvents"); synchErrThresholdFactor_ = _params.getUntrackedParameter("synchErrThresholdFactor"); } @@ -57,7 +58,7 @@ namespace ecaldqm { for (unsigned iS(0); iS < nFEFlags; iS++) { float entries(sFEStatus.getBinContent(getEcalDQMSetupObjects(), id, iS + 1)); towerEntries += entries; - if (entries > 0. && iS != Enabled && iS != Suppressed && iS != ForcedFullSupp && iS != FIFOFull && + if (entries > minEvents_ && iS != Enabled && iS != Suppressed && iS != ForcedFullSupp && iS != FIFOFull && iS != ForcedZS) towerStatus = doMask ? kMBad : kBad; }