diff --git a/[refs] b/[refs] index dbf41aef94016..f5de6eb7d9c20 100644 --- a/[refs] +++ b/[refs] @@ -1,2 +1,2 @@ --- -refs/heads/l1tmuon-upgrade-dev: 6d81c4bf2acd35e73c045c74344aa3aa496d89fc +refs/heads/l1tmuon-upgrade-dev: e638453f5d2355204ebd317cc649c6541588031c diff --git a/trunk/DataFormats/GeometrySurface/interface/Cylinder.h b/trunk/DataFormats/GeometrySurface/interface/Cylinder.h index 37bc656696013..a82922ce813e6 100644 --- a/trunk/DataFormats/GeometrySurface/interface/Cylinder.h +++ b/trunk/DataFormats/GeometrySurface/interface/Cylinder.h @@ -10,8 +10,8 @@ * using the static build() methods. * (The normal constructor will become private in the future). * - * $Date: 2010/12/22 10:17:24 $ - * $Revision: 1.3 $ + * $Date: 2010/12/22 10:43:10 $ + * $Revision: 1.4 $ */ #include "DataFormats/GeometrySurface/interface/Surface.h" @@ -65,14 +65,14 @@ class Cylinder : public virtual Surface { virtual ReferenceCountingPointer tangentPlane (const LocalPoint&) const; /// tangent plane to surface from global point - Plane fastTangent(const GlobalPoint& apoint) const{ - GlobalVector yPlane = rotation.z(); + Plane fastTangent(const GlobalPoint& aPoint) const{ + GlobalVector yPlane = rotation().z(); GlobalVector xPlane(yPlane.cross(aPoint-position())); return Plane(aPoint,RotationType(xPlane, yPlane)); } /// tangent plane to surface from local point - Plane fastTangent(const LocalPoint& apoint) const { + Plane fastTangent(const LocalPoint& aPoint) const { return fastTangent(toGlobal(aPoint)); } diff --git a/trunk/DataFormats/GeometrySurface/src/Cylinder.cc b/trunk/DataFormats/GeometrySurface/src/Cylinder.cc index cc8d3b8d43846..3c509aa898930 100644 --- a/trunk/DataFormats/GeometrySurface/src/Cylinder.cc +++ b/trunk/DataFormats/GeometrySurface/src/Cylinder.cc @@ -28,11 +28,11 @@ Cylinder::tangentPlane (const GlobalPoint& aPoint) const // to verify, if the point is actually on the cylinder. // // local y parallel to axis - GlobalVector yPlane = rotation.z(); + GlobalVector yPlane = rotation().z(); // local x normal to y and a vector linking the specified // point with the axis GlobalVector xPlane(yPlane.cross(aPoint-position())); - Scalar size = std::max(std::max(xPlane.x(),xPlane.y()), xPlane.z()); + Scalar size = std::max(std::max(std::abs(xPlane.x()),std::abs(xPlane.y())), std::abs(xPlane.z())); if ( size