Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weight storage in P8.303 #6688

Closed
agrohsje opened this issue Mar 1, 2021 · 9 comments
Closed

Weight storage in P8.303 #6688

agrohsje opened this issue Mar 1, 2021 · 9 comments

Comments

@agrohsje
Copy link

agrohsje commented Mar 1, 2021

P8.303 has modified handling of weights. Variables changed definition and needs adjustments:
8.302 8.303
fMaterGen->info.nWeights() 1 1
fMaterGen->info.weight() 25248.6.. 25248.6..
fMaterGen->info.numberOfWeights() 1 0
fMaterGen->info.weightValueByIndex(0) 25247.6.. N/A

There is a new option "doSuppressAUXweights". There seems a problem to read in LHE weights.
@mkirsano @SiewYan : This is the issue we discussed on Skype so we can centrally follow-up. Thanks.

@agrohsje
Copy link
Author

agrohsje commented Mar 1, 2021

assign generators

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

New categories assigned: generators

@alberto-sanchez,@SiewYan,@GurpreetSinghChahal,@mkirsano,@agrohsje you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2021

A new Issue was created by @agrohsje .

@Dr15Jones, @dpiparo, @silviodonato, @smuzaffar, @makortel, @qliphy can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@mkirsano
Copy link
Contributor

mkirsano commented Mar 8, 2021

I started to look, but there is not enough information. What is the configuration and lhe file that don't work? How do you see that the weights are not properly handled?

@menglu21
Copy link

Hi,
i did a check on request https://cms-pdmv.cern.ch/mcm/requests?prepid=TSG-Run3Winter21wmLHEGS-00001&page=0&shown=127, using the nanogen instead of the full simulation chain, the number of the PS weight seems fine, 89 for each event, but seems most of the PSweights are 1 which i'm not sure it's fine. you can check the fragment and configure file at https://melu.web.cern.ch/melu/WJets/, plot weight.png using 3417 events, and weight2.png are those with weights in (0.9,1.1)

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 22, 2021

@agrohsje do we need to keep this issue open here? Better to open an issue on cms-sw/cmssw to discuss.

@agrohsje
Copy link
Author

Hi @smuzaffar . Further checks are on my todo list but my recent tests were all fine, no problems. I agree with closing.

@agrohsje
Copy link
Author

+generators

@cmsbuild
Copy link
Contributor

This issue is fully signed and ready to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants