Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GEANT4 branch to Geant4 10.6 #42

Closed
civanch opened this issue Dec 9, 2019 · 10 comments
Closed

Switch GEANT4 branch to Geant4 10.6 #42

civanch opened this issue Dec 9, 2019 · 10 comments

Comments

@civanch
Copy link
Contributor

civanch commented Dec 9, 2019

A new Geant4 reference version is available : ~vnivanch/public/geant4-10-06/geant4

We need to use this new version in GEANT4 special IB.

This release require modifications in other external datasets:
PhotonEvaporation5.5 : ~vnivanch/public/PhotonEvaporation5.5
CLHEP version 2.4.1.3: https://gitlab.cern.ch/CLHEP/CLHEP/tree/CLHEP_2_4_1_3
VecGeom v1.1.5: https://gitlab.cern.ch/VecGeom/VecGeom/tree/v1.1.5

@cmsbuild
Copy link

cmsbuild commented Dec 9, 2019

A new Issue was created by @civanch Vladimir Ivantchenko.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos, @kpedro88 can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor

@civanch , I can not access your ~vnivanch/public/geant4-10-06/geant4 . Can we just get it from https://github.com/Geant4/geant4/releases or do you have any changes on top of it in your area?

@civanch
Copy link
Contributor Author

civanch commented Dec 11, 2019

@smuzaffar , unfortunately, there are to fixes (pure numerical for rare division by zero and precision lost) on top of the release. For some reason all cmake and gmake related files have strong permissions in this directory.
I will redo preparation from scratch and let you know when ready.

@smuzaffar
Copy link
Contributor

I think it is better to create a new branch using official geant4 sources and then we can apply the patches via PR

@smuzaffar
Copy link
Contributor

@civanch , https://github.com/cms-externals/geant4/tree/cms/v10.6.0 is based on official geant4 tag https://github.com/Geant4/geant4/tree/v10.6.0 . Can you make a PR with additional changes? Or if yor provide me a tar.gz then I can do a diff and apply changes myself

@fabiocos
Copy link

I agree it is better to have a clean start, and track whatever addition on top of that in a transparent way

@civanch
Copy link
Contributor Author

civanch commented Dec 11, 2019

@smuzaffar , yes, I agree with this, indeed this would be more transparent.

@smuzaffar
Copy link
Contributor

@civanch , do you have your updates? As a wrote, just provide me a tar with and I can make a PR

@civanch
Copy link
Contributor Author

civanch commented Dec 12, 2019

@smuzaffar , thanks, I will try making PR, simply missed that the branch is already there.

@smuzaffar
Copy link
Contributor

this has been integrated in geant4 external repo now. once cms-sw/cmssw#28637 is merged then we can move forward with geant4 10.6 integration in CMSSW GEANT4 IBs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants