Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cmder build is failing #2723

Closed
daxgames opened this issue Jul 18, 2022 · 6 comments · Fixed by #2725 or #2748
Closed

Cmder build is failing #2723

daxgames opened this issue Jul 18, 2022 · 6 comments · Fixed by #2725 or #2748
Assignees
@MartiUK
Milestone
1.4

Comments

@daxgames
Copy link
Member

@cmderdev/core @cmderdev/trusted-contributors anyone know how to fix this.

image
MartiUK added a commit that referenced this issue Jul 18, 2022
@MartiUK
Remove XP platform
c89ef96 
Fixes #2723
@MartiUK MartiUK mentioned this issue Jul 18, 2022
Closed
@Stanzilla
Copy link
Member

I would do exactly the same, yeah. Remove XP

@daxgames
Copy link
Member Author

Thought about that but thought it may be fixable in Appveyor by whomever manages that for us.

@MartiUK MartiUK mentioned this issue Jul 18, 2022
Merged
@MartiUK MartiUK added the 📌 Pinned Issue will not become stale label Jul 25, 2022
@MartiUK MartiUK added this to the 1.4 milestone Jul 25, 2022
@daxgames
Copy link
Member Author

daxgames commented Sep 4, 2022

@MartiUK Did you ever get this to build in Appveyor. I ask becasue I setup my fork in Appveyor and it does actually build PRs and create artifacts. The odd part is the artifacts have the wrong version file in them. They build as 1.3.6-pre*.

I know nothing about Appveyor and just setup a default project. Are there additional settings you specified in yours?

This was referenced Sep 9, 2022
Merged
Merged
daxgames added a commit that referenced this issue Sep 11, 2022
@daxgames
Merge pull request #2748 from DRSDavidSoft/master
3d0e6b8 
Fix build system scripts (closes #2723)
@DRSDavidSoft DRSDavidSoft reopened this Oct 17, 2022
@DRSDavidSoft
Copy link
Contributor

@MartiUK There is something wrong with the current AppVeyor configuration. We either need access to the configuration page to modify it, or access to admin settings of Cmder repo to change the CI to another account that have proper configurations.

@MartiUK
Copy link
Member

MartiUK commented Oct 18, 2022

Looks like it's building fine now, I re-ran with the latest commit

@MartiUK MartiUK self-assigned this Oct 18, 2022
@MartiUK MartiUK closed this as completed Oct 18, 2022
@DRSDavidSoft
Copy link
Contributor

Thanks for fixing it! 😄

@DRSDavidSoft DRSDavidSoft removed the 📌 Pinned Issue will not become stale label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MartiUK MartiUK

Labels
None yet
Projects
None yet
Milestone
1.4
4 participants
@Stanzilla @MartiUK @DRSDavidSoft @daxgames