From f6a2e73d77f3bd7669126041104763ff7e12d651 Mon Sep 17 00:00:00 2001 From: Colin Caine Date: Mon, 30 Mar 2020 21:45:10 +0100 Subject: [PATCH] Rename unexported isgreater in reduceddim --- base/reducedim.jl | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/base/reducedim.jl b/base/reducedim.jl index fe3adef035dec2..488fe5fdd18852 100644 --- a/base/reducedim.jl +++ b/base/reducedim.jl @@ -780,7 +780,7 @@ function _findmin(A, region) end end -isgreater(a, b) = isless(b,a) +_isgreater(a, b) = isless(b,a) """ findmax!(rval, rind, A) -> (maxval, index) @@ -791,7 +791,7 @@ dimensions of `rval` and `rind`, and store the results in `rval` and `rind`. """ function findmax!(rval::AbstractArray, rind::AbstractArray, A::AbstractArray; init::Bool=true) - findminmax!(isgreater, init && !isempty(A) ? fill!(rval, first(A)) : rval, fill!(rind,zero(eltype(keys(A)))), A) + findminmax!(_isgreater, init && !isempty(A) ? fill!(rval, first(A)) : rval, fill!(rind,zero(eltype(keys(A)))), A) end """ @@ -824,7 +824,7 @@ function _findmax(A, region) end similar(A, ri), zeros(eltype(keys(A)), ri) else - findminmax!(isgreater, fill!(similar(A, ri), first(A)), + findminmax!(_isgreater, fill!(similar(A, ri), first(A)), zeros(eltype(keys(A)), ri), A) end end