Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blasts against pdbfinder are missing residues #43

Open
jonblack opened this issue Nov 10, 2016 · 1 comment
Open

Blasts against pdbfinder are missing residues #43

jonblack opened this issue Nov 10, 2016 · 1 comment
Labels

Comments

@jonblack
Copy link
Contributor

The BLAST results from pdbfinder are missing residues. See cmbi/hommod#41.

@jonblack jonblack added the bug label Nov 10, 2016
@cbaakman
Copy link
Contributor

cbaakman commented Nov 10, 2016

Most likely the problem is in https://github.com/cmbi/mrs/blob/master/parsers/pdbfinder.pm#L117. The regular expression matching assumes that sequences contain only letters, no dashes.

We must think about what to do with line breaks. Completely ignoring them in blast might not be scientifically correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants