Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMcode-2020 problem with feedback at low k #135

Closed
alexander-mead opened this issue Jan 10, 2023 · 1 comment
Closed

HMcode-2020 problem with feedback at low k #135

alexander-mead opened this issue Jan 10, 2023 · 1 comment

Comments

@alexander-mead
Copy link
Contributor

It has been bought to my attention that there is a small problem with the HMcode-2020 feedback recipe at low k. Baryonic feedback should have a negligible effect on P(k) for k < 1e-2 h/Mpc, however, the HMcode-2020 feedback model erroneously predicts ~10% level effects at k = 1e-4 h/Mpc.

This is a bug, which I have now fixed. The before and after can be seen here:

Before:
before
After:
after

Are you able to give me permission to push my new branch, with the correction, to the CAMB repository? I think you can do this while protecting the master branch.

@cmbant
Copy link
Owner

cmbant commented Jan 10, 2023

Thanks - just generate a pull request from your own site? Usually easiest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants