The Stdio is now a well-behaving duplex stream #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Stdiois now a well-behaving duplex stream which will now emit each complete line asdataevents. If you need access to the raw input byte stream, consider using theStdinas a readable stream instead.The writable behavior is now also more predictable and stable. The test suite has been improved significantly.
This changeset also improves output performance significantly, most notably the output should no longer "flicker".
This is a BC break because the ctor arguments have been changed. This ctor is only used internally, so it should not affect any consumers of this lib.
Closes #17 and closes #34.
Builds on top of #32 and #33.